add support for Arch Linux and Fedora containers #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Looks good!
Maybe we could extend https://github.com/mxschmitt/action-tmate/blob/master/.github/workflows/manual-test.yml to include at least Fedora? I guess that could be a bit tricky because there are no hosted Fedora runners and we'd have to resort to Docker e.g. [the way Git does it][https://github.com/git/git/blob/v2.37.3/.github/workflows/main.yml#L274-L306). To be clear: this can easily be a follow-up PR, I'm in favor of this here PR as-is.
|
Okay, I'll send a follow-up PR later this week ! |
mxschmitt
reviewed
Oct 4, 2022
mxschmitt
approved these changes
Oct 4, 2022
|
Not sure what happened with the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the title says it
I tested the SSH connection and it works fine, both in Arch Linux and Fedora