Added Serenity/JS #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mxschmitt - looks like the linter is complaining about line 49... Is this something I should address? Thanks! |
|
@mxschmitt - That linting error should be fixed now. |
mxschmitt
reviewed
Dec 18, 2023
README.md
Outdated
| @@ -90,6 +91,7 @@ | |||
|
|
|||
| - [theheadless.dev](https://www.checklyhq.com/learn/headless/) - Practical guides and runnable examples on Playwright (and Puppeteer). | |||
| - [playwrightsolutions.com](https://playwrightsolutions.com) - Curated Selection of Playwright Automated Test Problems and Solutions. | |||
| - [serenity-js.org](https://serenity-js.org/handbook/web-testing/your-first-web-scenario/) - Learn to write high-quality, business-focused automated acceptance tests using Playwright and Serenity/JS. | |||
There was a problem hiding this comment.
high-quality and business-focused seems very opinionated. Should We maybe rephrase it?
Like: Learn to write tests using the Serenity/JS framework with the Screenplay Pattern.
There was a problem hiding this comment.
Thanks @mxschmitt, I rephrased it. Let me know if you're happy with the latest version.
mxschmitt
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.