Can we make DirectoryTestSuite.getTests() public? #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcesher
added a commit
that referenced
this pull request
Oct 1, 2013
Can we make DirectoryTestSuite.getTests() public?
|
Thanks Adam! |
|
Thanks, you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I made this thing that I think is pretty cool:
Only problem is that to make it I had to modify my MXUnit install and make 1 tiny change -- the one included in this pull request.
It simply makes the
getTestsmethod of themxunit.runner.DirectoryTestSuiteclass public instead of private. This is done so that I can get a list of the test suites and their associated tests in a very machine-usable format.I can't think of any harm that could come from changing the access level of this method; other than it would become part of the officially supported API of the framework and that might come with some maintenance concerns?
If you accept this pull request, then I can remove the pre-requisite of modifying your mxunit install in order to use mxunit-watcher. What do you say? :)