Cleanup addTest() #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw the same misspelling that stephen-condon caught, but also noticed that the else part of this function was mess. - Fixed "this.testSuite", supposed to be "this.testSuites" - newStruct and tests are extra variables that aren't needed - Using this.tempStruct so the ComponentObject is actually set. It wasn't being set on newStruct. - Added a TODO tag to the comment about missing functionality.
|
Thanks @bcass! Looking at this code, can we get rid of this.tempStruct entirely and go with just the newStruct variable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the same misspelling that stephen-condon caught, but also noticed that the else part of this function was mess.