Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't merge attribute arrays, only override wholesale #64

Open
kierenevans opened this issue Oct 23, 2020 · 1 comment
Open

Can't merge attribute arrays, only override wholesale #64

kierenevans opened this issue Oct 23, 2020 · 1 comment

Comments

@kierenevans
Copy link
Collaborator

kierenevans commented Oct 23, 2020

This leads to a lot of duplication of a harness into a project.

For example if a harness defines:

example:
  foo:
    - one
    - two
    - three

but we want to insert "one point five" between "one" and "two", we have to clone the whole array to the project:

example:
  foo:
    - one
    - one point five
    - two
    - three

This also affects removing something from the array. For example if we don't want two to happen:

example:
  foo:
    - one
    - ~

Ideally we'd be able to delete/insert as needed without replication, though this may become brittle for harness version upgrades if the array entry values were to change.

@andytson
Copy link

andytson commented Oct 23, 2020

I think the main problem is we can't override arrays with a subset of array items rather than overriding every entry, but an explicit way to reference the original also would be good. My problem with it is I want the implicit override to wipe the array completely.

There's similar issue for maps, we can't wipe a whole map, but doing that on maps should be explicit instead of implicit for arrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants