Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable static asset language and theme deployments #472

Merged

Conversation

kierenevans
Copy link
Contributor

Fixes #421

@kierenevans kierenevans added enhancement New feature or request hacktoberfest-accepted Accepted for Hacktoberfest harness-magento2 Magento 2.x harness labels Oct 20, 2020
@kierenevans kierenevans added this to the 0.11.0 milestone Oct 20, 2020
backend:
languages:
- en_GB
- en_US
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we can't turn off stores in spryker harness, but with the inherent array merge issues should we solve it for new work?

Copy link
Contributor

@andytson-inviqa andytson-inviqa Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or @dcole-inviqa could we have help in working out a fix to workspace itself?

Copy link
Contributor Author

@kierenevans kierenevans Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just re-read this comment. We define as empty in the harness to avoid this problem. This is for testing if it works in Jenkins with some defined settings. Dynamic one is deliberately empty to test that scenario too (which compiles all languages and themes).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created my127/workspace#64 to track this, as I know it's been bugging everyone

Copy link
Contributor

@andytson-inviqa andytson-inviqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be able to specify overridden single language. Theme is already a single item array so currently unaffected

@kierenevans kierenevans merged commit c3d1daf into 0.11.x Oct 23, 2020
@kierenevans kierenevans deleted the feature/customise-static-asset-languages-and-themes branch October 23, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Accepted for Hacktoberfest harness-magento2 Magento 2.x harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[magento2] Allow customising the languages to build static assets for
2 participants