-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisable static asset language and theme deployments #472
Customisable static asset language and theme deployments #472
Conversation
backend: | ||
languages: | ||
- en_GB | ||
- en_US |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we can't turn off stores in spryker harness, but with the inherent array merge issues should we solve it for new work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or @dcole-inviqa could we have help in working out a fix to workspace itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just re-read this comment. We define as empty in the harness to avoid this problem. This is for testing if it works in Jenkins with some defined settings. Dynamic one is deliberately empty to test that scenario too (which compiles all languages and themes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have created my127/workspace#64 to track this, as I know it's been bugging everyone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to be able to specify overridden single language. Theme is already a single item array so currently unaffected
Fixes #421