Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Suggestion: Declare all annotations with const #605

Closed
myConsciousness opened this issue Jul 19, 2023 · 0 comments · Fixed by #608
Closed

Improve Suggestion: Declare all annotations with const #605

myConsciousness opened this issue Jul 19, 2023 · 0 comments · Fixed by #608
Assignees
@myConsciousness
Labels
atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`.

Comments

@myConsciousness
Copy link
Owner

1. What could be improved

2. Why should this be improved

3. Any risks?

4. More information
@myConsciousness myConsciousness added enhancement atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. labels Jul 19, 2023
@myConsciousness myConsciousness self-assigned this Jul 19, 2023
myConsciousness added a commit that referenced this issue Jul 20, 2023
@myConsciousness
🚀 refactor: made AtUriConverter const (#605)
442a75b
myConsciousness added a commit that referenced this issue Jul 20, 2023
@myConsciousness
🚀 refactor: made BlobConverter const (#605)
aa07cdc
myConsciousness added a commit that referenced this issue Jul 20, 2023
@myConsciousness
🚀 refactor: made NsidConverter const (#605)
f88ae98
myConsciousness added a commit that referenced this issue Jul 20, 2023
@myConsciousness
🚀 refactor: made annotations const (#605)
b39221d
@myConsciousness myConsciousness linked a pull request Jul 20, 2023 that will close this issue
🚀 refactor: made annotations const (#605) #608
Merged
7 tasks
myConsciousness added a commit that referenced this issue Jul 20, 2023
@myConsciousness
Merge pull request #608 from myConsciousness/605-improve-suggestion-d…
07ca111 
…eclare-all-annotations-with-const

🚀 refactor: made annotations const (#605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚀 refactor: made annotations const (#605) myConsciousness/atproto.dart
1 participant
@myConsciousness