Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Consider the ability to aggregate .findNotifications results #728

Closed
1 of 12 tasks
myConsciousness opened this issue Sep 1, 2023 · 0 comments · Fixed by #739
Closed
1 of 12 tasks

Feature Request: Consider the ability to aggregate .findNotifications results #728

myConsciousness opened this issue Sep 1, 2023 · 0 comments · Fixed by #739
Assignees
@myConsciousness
Labels
bluesky A label indicating the package `bluesky`. feat A label indicating that this issue is a new feature. help wanted Extra attention is needed

Comments

@myConsciousness
Copy link
Owner

myConsciousness commented Sep 1, 2023 •
edited
Loading

Packages/Tools

  • at_identifier
  • nsid
  • at_uri
  • xrpc
  • multiformats
  • atproto_core
  • atproto
  • bluesky
  • bluesky_text
  • bluesky_cli
  • bluesky_post
  • others

Proposal

https://github.com/bluesky-social/social-app/blob/4cd3ddecadfaad1e1711b916760590cd18fba675/src/state/models/feeds/notifications.ts#L634-L662

And add GroupedNotifications and GroupedNotification objects.

GroupedNotification {
  List<String> cids,
  List<AtUri> uris,
  List<Actor> authors,
  NotificationReason reason,
  StrongRef? subject,
  List<Labels> labels,
  bool isRead,
  DateTime indexedAt,
}

Risks
@myConsciousness myConsciousness added help wanted Extra attention is needed bluesky A label indicating the package `bluesky`. untriaged A label Indicating this Issue has not yet been initiated. feat A label indicating that this issue is a new feature. labels Sep 1, 2023
@myConsciousness myConsciousness self-assigned this Sep 1, 2023
@myConsciousness myConsciousness removed the untriaged A label Indicating this Issue has not yet been initiated. label Sep 2, 2023
myConsciousness added a commit that referenced this issue Sep 2, 2023
@myConsciousness
✨ feat: group notifications (#728)
3476657
@myConsciousness myConsciousness linked a pull request Sep 2, 2023 that will close this issue
✨ feat: group notifications (#728) #739
Merged
6 tasks
myConsciousness added a commit that referenced this issue Sep 3, 2023
@myConsciousness
✨ feat: grouped notifications (#728)
6883b5c
myConsciousness added a commit that referenced this issue Sep 3, 2023
@myConsciousness
✨ feat: added includeReasons (#728)
b85d0fb
myConsciousness added a commit that referenced this issue Sep 3, 2023
@myConsciousness
✨ feat: added includeReasons (#728)
671cd5f
myConsciousness added a commit that referenced this issue Sep 3, 2023
@myConsciousness
Merge pull request #739 from myConsciousness/728-feature-request-cons…
379960d 
…ider-the-ability-to-aggregate-findnotifications-results

✨ feat: group notifications (#728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
bluesky A label indicating the package `bluesky`. feat A label indicating that this issue is a new feature. help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat: group notifications (#728) myConsciousness/atproto.dart
1 participant
@myConsciousness