Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Suggestion: reasonSubject is nullable #743

Closed
1 of 12 tasks
myConsciousness opened this issue Sep 3, 2023 · 0 comments · Fixed by #744
Closed
1 of 12 tasks

Improve Suggestion: reasonSubject is nullable #743

myConsciousness opened this issue Sep 3, 2023 · 0 comments · Fixed by #744
Assignees
Labels
bluesky A label indicating the package `bluesky`. help wanted Extra attention is needed

Comments

@myConsciousness
Copy link
Owner

Packages/Tools

  • at_identifier
  • nsid
  • at_uri
  • xrpc
  • multiformats
  • atproto_core
  • atproto
  • bluesky
  • bluesky_text
  • bluesky_cli
  • bluesky_post
  • others

Proposal

  @jsonSerializable
  const factory GroupedNotification({
    /// The collection of authors causing the notification.
    required List<Actor> authors,

    /// Specifies the reason for the notification.
    required NotificationReason reason,

    /// Optionally, represents the subject of the reason for the notification.
    @atUriConverter AtUri? reasonSubject,

    /// Indicates whether the notification has been read or not.
    required bool isRead,

    /// May include any labels attached to the notification.
    required List<Label> labels,

    /// Indicates the timestamp at which the notification was indexed.
    required DateTime indexedAt,
  }) = _GroupedNotification;

Risks

@myConsciousness myConsciousness added help wanted Extra attention is needed bluesky A label indicating the package `bluesky`. labels Sep 3, 2023
@myConsciousness myConsciousness self-assigned this Sep 3, 2023
@myConsciousness myConsciousness linked a pull request Sep 3, 2023 that will close this issue
6 tasks
myConsciousness added a commit that referenced this issue Sep 3, 2023
…easonsubject-is-nullable

🔧 fix: `reasonSubject` is nullable (#743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluesky A label indicating the package `bluesky`. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant