Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added facets (#247) #247

Merged
merged 5 commits into from
Apr 11, 2023
Merged

feat: added facets (#247) #247

merged 5 commits into from
Apr 11, 2023

Conversation

myConsciousness
Copy link
Owner

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Apr 11, 2023
@github-actions github-actions bot added bluesky A label indicating the package `bluesky`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. documentation Improvements or additions to documentation labels Apr 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #247 (28afe43) into main (5a2e0d3) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   78.49%   78.07%   -0.42%     
==========================================
  Files         100      101       +1     
  Lines         744      748       +4     
==========================================
  Hits          584      584              
- Misses        160      164       +4     
Impacted Files Coverage Δ
packages/bluesky/lib/src/entities/facet_link.dart 100.00% <ø> (ø)
...ckages/bluesky/lib/src/entities/facet_mention.dart 100.00% <ø> (ø)
packages/bluesky/lib/src/entities/reply_ref.dart 0.00% <0.00%> (ø)
packages/bluesky/lib/src/feeds/feeds_service.dart 95.00% <0.00%> (-5.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness myConsciousness changed the title feat: added facets feat: added facets (#247) Apr 11, 2023
@myConsciousness myConsciousness merged commit b8cf279 into main Apr 11, 2023
@myConsciousness myConsciousness deleted the feat-bluesky-add-facets branch April 11, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluesky A label indicating the package `bluesky`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants