-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest WELD #49
Comments
I am ok with upgrade, any very old project can keep using old beta versions. |
Hi @hazendaz I have upgraded to WELD 2.4.1, everything is working in my environment, but it fails on TravisCI, looks like a class version problem (maybe jdk version). Can you please check? |
Commit aa90970 change to remove serialization breaks the tests. I'm going to add it back but suspect weld might also be on java 7 in recent versions. |
OK So I was incorrect on servlet 2.5 support drop. That actually occurred on 2.2 release. here. So we already dropped it to. So what was stopping us was dropping java 6 support. I personally don't see much reason to support 6. Considering we obviously dropped servlet 2.5 at some point we don't support any old containers and I would like to hope bulk of users that might use this would be on 7 at least in servlet 3.x containers. We can roll back though as there were no code changes as a result. If you want to stay here, we will just need to remove java 6 from the travis ci build. |
btw being that project is not huge, I turned on formatting during build. It trashes a bit due to license having spacing that conflicts so it always formats all 28 java files then applies header. You may not notice that. Also formatter at this point is based on Luna so on next mybatis parent it will raise to Mars which will fix some of the issues that formatted strangely. |
Closing as fixed by removing java 6 build. Weld requires java 7 now. |
Since servlet 2.5 is generally now EOL with both tomcat and spring calling it quits, should we go ahead and upgrade to latest weld 2.4.x? The obvious there is that servlet 2.5 support will be dropped.
The text was updated successfully, but these errors were encountered: