-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
before_new and after_new hooks #106
Comments
I am also willing to fold-in a dockerfile as per #105 to see this change accepted. |
Hi @chb0github , Could you elaborate on the use case? |
When a new migration is created we need to create a few other corresponding
resources based on the file to be created. In addition, it allows
flexibility for doing validation on the naming of the file as they are
based on jira tickets
…On Mon, Dec 11, 2017, 4:39 PM Iwao AVE! ***@***.***> wrote:
Hi @chb0github <https://github.com/chb0github> ,
Could you elaborate on the use case?
new command is rather unique and we may need to know what you are trying
to achieve with the hooks to make it useful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#106 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABaI0BXbcFPxv-I8rQ_ihjBMdDPLeBQPks5s_csvgaJpZM4Q95en>
.
|
To be clear, it's a feature I am willing to implement. I just need to know
it will be folded in if implemented
On Mon, Dec 11, 2017, 7:00 PM Christian Bongiorno <
christian.bongiorno@gmail.com> wrote:
… When a new migration is created we need to create a few other
corresponding resources based on the file to be created. In addition, it
allows flexibility for doing validation on the naming of the file as they
are based on jira tickets
On Mon, Dec 11, 2017, 4:39 PM Iwao AVE! ***@***.***> wrote:
> Hi @chb0github <https://github.com/chb0github> ,
>
> Could you elaborate on the use case?
> new command is rather unique and we may need to know what you are trying
> to achieve with the hooks to make it useful.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#106 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABaI0BXbcFPxv-I8rQ_ihjBMdDPLeBQPks5s_csvgaJpZM4Q95en>
> .
>
|
Thank you for the explanation! There is one thing I would like to discuss first. As a background, Cc-ing @h3adache . |
I don't have much knowledge on the subject, but let me ask: What's the difference between put it all in As for the hooks: I would say that git has the right idea: create a And, putting them in a So, like |
I have a working implementation of |
Thank you, @chb0github . |
I would like to implement before/after
new
hooks as they exist for the other hooks. Any objections?The text was updated successfully, but these errors were encountered: