Allow collection or array object on item attribute of foreach element #1075
Conversation
| @@ -154,7 +154,7 @@ public void appendSql(String sql) { | |||
| GenericTokenParser parser = new GenericTokenParser("#{", "}", new TokenHandler() { | |||
| @Override | |||
| public String handleToken(String content) { | |||
| String newContent = content.replaceFirst("^\\s*" + item + "(?![^.,:\\s])", itemizeItem(item, index)); | |||
| String newContent = content.replaceFirst("^\\s*" + item + "(?![^.\\[,:\\s])", itemizeItem(item, index)); | |||
| if (itemIndex != null && newContent.equals(content)) { | |||
| newContent = content.replaceFirst("^\\s*" + itemIndex + "(?![^.,:\\s])", itemizeItem(itemIndex, index)); | |||
There was a problem hiding this comment.
Is there any particular reason why the same change is not applied to this line?
There was a problem hiding this comment.
@harawata Thanks for your review!
The itemIndex is variable name for representing a integer value. In other words, there is no case that it have a array/collection object. Therefore I think it not need applying same change.
WDYT ?
There was a problem hiding this comment.
When a map is passed as collection, index represents the key of each entry.
So, technically, it can be a list or array, I think.
(I haven't had time to verify it)
There was a problem hiding this comment.
Yeah. Although it's a neat feature, not many users need it, I guess :)
|
Hi @harawata , I withdraw this PR because i found more considerations are need. |
|
OK. Thank you for your work! |
Fixes gh-1074
Please review this.