-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NullableBaseTypeHandler for avoid unnecessary wasNull() call #1242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, @lseeker ! This seems like a nice optimization. |
+1. Sounds good!
El mié., 4 de abril de 2018 1:05 PM, Iwao AVE! <notifications@github.com>
escribió:
… Thank you, @lseeker <https://github.com/lseeker> !
This seems like a nice optimization.
Any objections?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1242 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCXVQ_7yI8DuL9ZiiergwTtXPdA9ONEks5tlQt4gaJpZM4THDRG>
.
|
Sounds good me too!! |
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
The original PR is mybatis#1242
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
The original PR is mybatis#1242
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 5, 2018
@kazuki43zoo Thanks for improved work! |
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 9, 2018
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Apr 9, 2018
kazuki43zoo
added a commit
that referenced
this pull request
Apr 25, 2018
…class Move wasNull to subclass from BaseTypeHandler #1242
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
…-to-subclass Move wasNull to subclass from BaseTypeHandler mybatis#1242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current MyBatis type handlers always check SQL NULL by ResultSet.wasNull() call that could decrease performance.
On my case on Oracle R12, profiling found about 30% delay on VARCHAR types by wasNull() call.
Following java.sql.ResultSet get methods are declared returns java null on SQL NULL value, so these types are can use returned null value as-is.
This pull request add NullableBaseTypeHandler class that do not call wasNull() and inherits it on TypeHandlers using above listed methods.