Move wasNull to subclass from BaseTypeHandler #1242 #1244
Conversation
|
You work fast 🙀 @mnesarco @h3adache Please comment if you guys noticed anything! |
kazuki43zoo
force-pushed
the
gh-1242_move-wasNull-to-subclass
branch
from
44cec15
to
9d6bd53
Compare
kazuki43zoo
added
enhancement
| @@ -38,19 +38,19 @@ public void setNonNullParameter(PreparedStatement ps, int i, Object parameter, J | |||
| @Override | |||
| public Object getNullableResult(ResultSet rs, String columnName) throws SQLException { | |||
| Array array = rs.getArray(columnName); | |||
| return array == null ? null : array.getArray(); | |||
| return (array == null || rs.wasNull()) ? null : array.getArray(); | |||
There was a problem hiding this comment.
A lot of your changes are because of this logic.
I'm curious what driver returns a non null for an object type but returns true for rs.wasNull()
I've only see it happen for primitive types but never for object types
There was a problem hiding this comment.
@h3adache , Thanks for your comment. You're right! I've confirmed the JDBC 4.2 specification, it says about NULL values as follow:
15.2.3.3 Retrieving NULL values
The method wasNull can be called to determine if the last value retrieved was a
SQL NULL in the database.
When the column value in the database is SQL NULL, it may be returned to the Java
application as null, 0, or false, depending on the type of the column value.
Column values that map to Java Object types are returned as a Java null; those
that map to numeric types are returned as 0; those that map to a Java boolean are
returned as false. Therefore, it may be necessary to call the wasNull method to
determine whether the last value retrieved was a SQL NULL.
I will modify it at tonight(JST).
|
Sorry I got pulled away before I finished the code review. Everything else looks good. |
kazuki43zoo
force-pushed
the
gh-1242_move-wasNull-to-subclass
branch
from
9d6bd53
to
28ddddd
Compare
kazuki43zoo
force-pushed
the
gh-1242_move-wasNull-to-subclass
branch
from
28ddddd
to
2b68768
Compare
|
I've fixed @h3adache 's comment. (Revert some classes to original version) |
|
I've merged this. If there is a problem, please give a comment. |
|
Remain task:
|
…-to-subclass Move wasNull to subclass from BaseTypeHandler mybatis#1242
I've fixed #1242 based on the comment of #1243 by @harawata .
About backword compatility
In this change, type handlers provided by the mybatis core project keeps backward compatibility. But If you used the method that returned type is primitive(e.g.
ResultSet#getInt) in your type handler, there is need a notice that it may be lost backward compatibility.If you used the method that returned type is primitive, please consider to change as calling
wasNullin your type handler.