made closeConnection in the Runner classes deprecated #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything else I can do to help? :) |
harawata
requested changes
Dec 26, 2019
There was a problem hiding this comment.
Thank you for your work, @mustaphazorgati !
We now add @deprecated since in javadoc comment, it seems.
Please see the comments.
@kazuki43zoo ,
Any concern with the deprecation or the changes?
Because the Runners are not responsible to close the connection
mustaphazorgati
force-pushed
the
master
branch
from
e1540e2
to
303fd65
Compare
harawata
approved these changes
Dec 28, 2019
harawata
added
the
polishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Runners are not responsible to close the connection.