Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if edit a post with admin that post changed to unapproved #1050

Closed
DiogoParrinha opened this issue Jul 26, 2014 · 5 comments
Closed

if edit a post with admin that post changed to unapproved #1050

DiogoParrinha opened this issue Jul 26, 2014 · 5 comments
Assignees
@Sama34
Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.0

Comments

@DiogoParrinha
Copy link
Contributor

if edit a post with admin account, that post changed to unapproved

Original thread: if edit a post with admin that post changed to unapproved
@DiogoParrinha DiogoParrinha added this to the 1.8.0 milestone Jul 26, 2014
@DiogoParrinha
Copy link
Contributor Author

Not sure how this happened, it was working fine on Beta 2 IIRC. So a bug fix or an enhancement has broken it.

@martec
Copy link
Contributor

martec commented Jul 29, 2014

i find line that cause this issue...
line 1817 of inc/datahandlers/post.php...

if($forumpermissions['mod_edit_posts'] != 1 && !$ismod)

@Sama34 added "&& !$ismod" in line above in 404a45d#diff-7cc617e1e9d4b3ffa6409eb9329f6801R1817, i don´t know intention of @Sama34 to add "&& !$ismod" in this line, so i don´t know if can remove "&& !$ismod" to fix this issue...

@Sama34
Copy link
Contributor

Sama34 commented Jul 29, 2014

Oh maybe it should be:

if($forumpermissions['mod_edit_posts'] != 1 || $ismod)

@Sama34 Sama34 self-assigned this Jul 29, 2014
@DiogoParrinha
Copy link
Contributor Author

@Sama34 this is important and it seems to be assigned to you.

@Sama34 Sama34 added s:fixed and removed s:confirmed labels Aug 3, 2014
@Sama34 Sama34 mentioned this issue Aug 3, 2014
Merged
DiogoParrinha pushed a commit that referenced this issue Aug 3, 2014
Merge pull request #1103 from Sama34/fix-1050
6e64aaa 
Fixes #1050 if edit a post with admin that post changed to unapproved
@DiogoParrinha
Copy link
Contributor Author

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sama34 Sama34

Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
3 participants
@DiogoParrinha @Sama34 @martec