Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlhttp improvements #1653

Closed
4 tasks
Destroy666x opened this issue Nov 22, 2014 · 3 comments
Closed
4 tasks

xmlhttp improvements #1653

Destroy666x opened this issue Nov 22, 2014 · 3 comments
Assignees
@Destroy666x
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8.13

Comments

@Destroy666x
Copy link
Contributor

  • as mentioned here: Fix #1648 #1649 I'm nearly sure username_exists isn't used anywhere so it can be removed. Correct me if I'm wrong. @mybb/developers
  • there is username AJAX validation during registration. but duplicate/invalid Email validation doesn't exist in xmlhttp.php, so an inline error is printed instead after submitting the form. Would be nice to add it.
  • passwords are checked against username/Email for being the same (insecure), not by AJAX though - another thing that would be nice to add
  • get_users action lists all users that begin with a search term, but would be nice to check all users that contain it instead. http://community.mybb.com/thread-168070-post-1145266.html#pid1145266 + possibly return UIDs (which are already selected in queries) if noone disagrees (?): http://community.mybb.com/thread-171952.html
@Destroy666x Destroy666x added t:enhancement Type: Enhancement. Contains minor improvements b:1.8 Branch: 1.8.x labels Nov 22, 2014
@Destroy666x Destroy666x self-assigned this Nov 22, 2014
@Destroy666x Destroy666x added this to the 1.8.5 milestone Nov 22, 2014
@JN-Jones JN-Jones modified the milestones: 1.8.5, 1.8.6 Apr 30, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.6, 1.8.7 Aug 26, 2015
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.7, 1.8.8 Mar 2, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.8, 1.8.9 Aug 31, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.9, 1.8.10 Dec 15, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.10, 1.8.11 Jan 8, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.11, 1.8.12 Apr 1, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.11 Apr 1, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.13 May 22, 2017
JordanMussi added a commit to JordanMussi/MyBB that referenced this issue Jul 6, 2017
@JordanMussi
Fixes mybb#1653 xmlhttp improvements
f692a3a
@JordanMussi JordanMussi mentioned this issue Jul 6, 2017
Merged
@JordanMussi
Copy link
Contributor

Fixed in #2790

@Eldenroot
Copy link
Contributor

Great, you are on fire! Thank you!!!!

euantorano pushed a commit that referenced this issue Sep 29, 2017
@JordanMussi @euantorano
Fixes #1653 xmlhttp improvements (#2790)
87f833e
@euantorano euantorano added the s:resolved Status: Resolved. Solution implemented or scheduled label Sep 29, 2017
@WildcardSearch
Copy link
Contributor

In my opinion username_exists should be left as it is a part of the API-- removing it could break plugins dependent on it.

Eldenroot pushed a commit to Eldenroot/mybb that referenced this issue May 8, 2018
@JordanMussi @Eldenroot
Fixes mybb#1653 xmlhttp improvements (mybb#2790)
95ca85b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Destroy666x Destroy666x

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8.13
Development

No branches or pull requests
7 participants
@Stefan-MyBB @euantorano @Eldenroot @JN-Jones @WildcardSearch @JordanMussi @Destroy666x