Unlisted "maxreputationsperuser" setting

[Destroy666x]

The maxreputationsperuser setting can be changed when the corresponding POST value is added manually to the request updating group settings, but is not listed.

https://github.com/mybb/mybb/search?utf8...onsperuser

RE: http://community.mybb.com/thread-186824.html

Original thread: Unlisted "maxreputationsperuser" setting

[Destroy666x]

mybb/reputation.php

Lines 108 to 152 in c1c94f0

	if($mybb->usergroup['maxreputationsday'] != 0 && ($mybb->input['action'] != "do_add" || ($mybb->input['action'] == "do_add" && empty($mybb->input['delete']))))
	{
	$timesearch = TIME_NOW - (60 * 60 * 24);
	$query = $db->simple_select("reputation", "*", "adduid='".$mybb->user['uid']."' AND dateline>'$timesearch'");
	$numtoday = $db->num_rows($query);
	// Reached the quota - error.
	if($numtoday >= $mybb->usergroup['maxreputationsday'])
	{
	$message = $lang->add_maxperday;
	if($mybb->input['nomodal'])
	{
	eval("\$error = \"".$templates->get("reputation_add_error_nomodal", 1, 0)."\";");
	}
	else
	{
	eval("\$error = \"".$templates->get("reputation_add_error", 1, 0)."\";");
	}
	echo $error;
	exit;
	}
	}
	// Is the user giving too much reputation to another?
	if($mybb->usergroup['maxreputationsperuser'] != 0 && ($mybb->input['action'] != "do_add" || ($mybb->input['action'] == "do_add" && empty($mybb->input['delete']))))
	{
	$timesearch = TIME_NOW - (60 * 60 * 24);
	$query = $db->simple_select("reputation", "*", "uid='".$uid."' AND dateline>'$timesearch'");
	$numtoday = $db->num_rows($query);
	if($numtoday >= $mybb->usergroup['maxreputationsperuser'])
	{
	$message = $lang->add_maxperuser;
	if($mybb->input['nomodal'])
	{
	eval("\$error = \"".$templates->get("reputation_add_error_nomodal", 1, 0)."\";");
	}
	else
	{
	eval("\$error = \"".$templates->get("reputation_add_error", 1, 0)."\";");
	}
	echo $error;
	exit;
	}
	}

We're checking 2 group options with the same functionality for some reason... maxreputationsday is correct and listed in ACP, remainders of maxreputationsperuser should be removed.

Unless it's supposed to be max reputations per account (permamently, not just a day), then the code should be changed and the group option added to ACP. Who knows, it was partially added a long time ago. I'd personally go with this option rather than removing it.

EDIT: nvm, didn't notice another UID being used in the query for the first time, it's supposed to be "Maximum Receivable Reputations Per Day". And it should be added to:

• usergroups.xml
• ACP group edit
• $groupzerogreater arrays

EDIT2: and the "You've already given this user as many reputation ratings as you can for today." error message is also wrong because it affects everybody, not just "you". It should be either changed or the query should also check adduid.