Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve/unapprove threads moderator permission broken #2592

Closed
Matslom opened this issue Jan 7, 2017 · 1 comment
Closed

Approve/unapprove threads moderator permission broken #2592

Matslom opened this issue Jan 7, 2017 · 1 comment
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone

Comments

@Matslom
Copy link
Contributor

Matslom commented Jan 7, 2017

When adding a moderator, there are two options:

Can approve/unapprove threads?

Can approve/unapprove posts?

However, enabling the setting to (un)approve threads does not show the option to (un)approve threads on the forum display, instead it checks the posts setting:

PHP Code:if(is_moderator($fid, "canapproveunapproveposts")){    eval("\$inlinemodapproveunapprove = \"".$templates->get("forumdisplay_inlinemoderation_approveunapprove")."\";");} 
So basically, you can only (un)approve threads, if you have the permission to (un)approve posts. The check in forumdisplay.php should check canapproveunapprovethreads instead. The check in showthread.php seems fine.

Original thread: Approve/unapprove threads moderator permission broken

@Matslom Matslom added b:1.8 Branch: 1.8.x t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists labels Jan 7, 2017
@Starpaul20 Starpaul20 added this to the 1.8.10 milestone Jan 7, 2017
@Starpaul20 Starpaul20 self-assigned this Jan 7, 2017
@Eldenroot
Copy link
Contributor

@Ben-Conway - can you please add "fixed" tag?

@Ben-MyBB Ben-MyBB added the s:resolved Status: Resolved. Solution implemented or scheduled label Jan 7, 2017
@dvz dvz removed the s:confirmed Status: Confirmed. Retested and found the issue exists label Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Development

No branches or pull requests

5 participants