Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme selector leaves GET data in the URL #2618

Closed
dvz opened this issue Jan 13, 2017 · 0 comments
Closed

Theme selector leaves GET data in the URL #2618

dvz opened this issue Jan 13, 2017 · 0 comments
Assignees
@Shade-
Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.11

Comments

@dvz
Copy link
Member

dvz commented Jan 13, 2017 •
edited by Starpaul20
Loading

The footer theme selector passes data, including the anti-CSRF token using GET and doesn't redirect the page after the request is handled, leaving it in the URL. Also affects footer language selector.

The data should be passed via POST.
@dvz dvz added b:1.8 Branch: 1.8.x t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists labels Jan 13, 2017
@dvz dvz added this to the 1.8.11 milestone Jan 13, 2017
@dvz dvz added the p:high Priority: High. To resolve with high preference label Feb 4, 2017
@Shade- Shade- mentioned this issue Feb 5, 2017
Merged
@Shade- Shade- self-assigned this Feb 5, 2017
Starpaul20 pushed a commit that referenced this issue Feb 7, 2017
@Shade- @Starpaul20
Fix #2618 (#2654)
d89eb8d 
* Changed method for the theme selector to POST

* Changed form method for languageselect
@Shade- Shade- added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shade- Shade-

Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.11
Development

No branches or pull requests
2 participants
@Shade- @dvz