Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update google recaptcha #2699

Closed
andrewjs18 opened this issue Mar 10, 2017 · 11 comments
Closed

update google recaptcha #2699

andrewjs18 opened this issue Mar 10, 2017 · 11 comments
Labels
3rdparty Third party; related to products maintained by other organization b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@andrewjs18
Copy link
Contributor

google has rolled out their invisible recaptcha. we should update the current recaptcha to the latest available from google.

https://www.google.com/recaptcha/intro/invisible.html

https://developers.google.com/recaptcha/...uto_render

Original thread: update google recaptcha

@andrewjs18 andrewjs18 added b:1.8 Branch: 1.8.x t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists 3rdparty Third party; related to products maintained by other organization t:enhancement Type: Enhancement. Contains minor improvements and removed t:bug Type: Bug. An issue causing error / flaw / malfunction labels Mar 10, 2017
@andrewjs18 andrewjs18 added this to the 1.8.11 milestone Mar 10, 2017
@Shade-
Copy link
Contributor

Shade- commented Mar 25, 2017

Should we replace the old Google Captcha method, or add the invisible approach as an option? @mybb/developers

@kawaii
Copy link
Member

kawaii commented Mar 25, 2017

@Shade- I would recommend adding it as an option, offers forum owners more flexibility.

@Eldenroot
Copy link
Contributor

Would be better to have both methods. Will be the old Google Captcha supported or will be replaced soon by invisibile approach, dont you know?

@euantorano
Copy link
Member

Add it as an option, for definite. Both styles are currently supported by Google, with no announced possibility of this changing any time soon as far as I know.

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.11, 1.8.12 Apr 1, 2017
@elaine-jackson
Copy link
Contributor

Just a note the developer link mentioned earlier in this thread is broken. However documentation for reCAPTCHA Invisible can be found at https://developers.google.com/recaptcha/docs/invisible

@elaine-jackson
Copy link
Contributor

So the other day I looked into how this would need to be implemented. The recaptcha attributes would need to be added to the registration submission button since there isn't a check box.

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.13 May 22, 2017
@Shade-
Copy link
Contributor

Shade- commented Jul 25, 2017

I have written down a preliminary version of this update, but for an unknown reason to me Google keeps on prompting me the visible reCAPTCHA. Please test it acknowledging it's a blindly written code.

Commit: 0321bac

@Shade- Shade- added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Aug 10, 2017
@Eldenroot
Copy link
Contributor

@Shade- any success? Fingers crossed!

@Shade-
Copy link
Contributor

Shade- commented Aug 10, 2017

The code is there, it needs testing.

@Eldenroot
Copy link
Contributor

@Shade- Is it working for you? Maybe I applied your changes in a wrong way but it is not working for me, I will let you know. Would be nice to have it in v1.8.13. What about others, MyBB team?

@Eldenroot
Copy link
Contributor

This can be closed - added via #2696

@Shade- Shade- closed this as completed Oct 24, 2017
@Starpaul20 Starpaul20 added this to the 1.8.13 milestone Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rdparty Third party; related to products maintained by other organization b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

8 participants