Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM search - incorrect folder #3666

Closed
effone opened this issue May 24, 2019 · 4 comments · Fixed by #3668
Closed

PM search - incorrect folder #3666

effone opened this issue May 24, 2019 · 4 comments · Fixed by #3668
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction t:regression Type: Regression. Degraded functionality after update
Milestone
1.8.21

Comments

@effone
Copy link
Member

effone commented May 24, 2019

When you search PMs, incorrect folders are displayed. It seems it reports "Unread" for all messages in "Inbox".

Original thread: PM search - incorrect folder
@effone effone added b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction t:regression Type: Regression. Degraded functionality after update labels May 24, 2019
@effone effone added this to the 1.8.21 milestone May 24, 2019
@MinusPL
Copy link
Contributor

MinusPL commented May 24, 2019

Almost fixed that. Need to test it more and will create PR soon.

MinusPL added a commit to MinusPL/mybb that referenced this issue May 24, 2019
@MinusPL
FIX mybb#3666 - PM search - incorrect folder
45fa502
@effone
Copy link
Member Author

effone commented May 25, 2019 •
edited

@MinusPL pardon me but the changes don't appear right to me.
Let me make you clear about few points.

  • The old folder value is maintained in database (to support existing data before changes). So there is no chance folder can be 0.
  • Only the folder structure is modified for representation purpose. So, folder 0 is Inbox and folder 1 is Unread its a wrong concept. For both cases its 1. Still for safeside you can query the value with < 2.
  • At runtime the fid is set to 0 based on folder value < 2 as inbox and all the messages not having readtime and / or status 0 considered as unread.
  • We don't need to display the message in unread folder at all in our search results. Its not even a folder in practical, its more like a status filter. To filter the Unread in advanced search there is a separate checkbox option labeled as "New".

@effone effone mentioned this issue May 25, 2019
Merged
@effone effone added the s:resolved Status: Resolved. Solution implemented or scheduled label May 25, 2019
@effone effone mentioned this issue May 25, 2019
Closed
@MinusPL
Copy link
Contributor

MinusPL commented May 25, 2019 •
edited

@effone
So basically folders are left in db only because these were used in earlier system?
I think that this whole private message system is in need of changes considering how it is currently working. And this leftover value made me think it was causing this issue.
I think I saw somewhere on community forum that there's plan to change it or update it for 1.9 or 1.10.
For now your way of fixing this issue is good.
Thanks for your reply, and thanks for your work.

@effone
Copy link
Member Author

effone commented May 25, 2019

Messaging system is expected to be revamped in future. Yes.
We have all enthusiasm left yet to carry MyBB with its all glory. Cross finger.

@dvz dvz added s:review-needed Status: Review Needed. Possible solution submitted and removed s:resolved Status: Resolved. Solution implemented or scheduled s:confirmed Status: Confirmed. Retested and found the issue exists labels May 28, 2019
@kawaii kawaii mentioned this issue May 30, 2019
Closed
euantorano pushed a commit that referenced this issue May 31, 2019
@effone @euantorano
Fixes #3666 PM search - incorrect folder (#3668)
06c060b 
* Search result folder reset

* Omit Unread in advanced search form
@euantorano euantorano added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:review-needed Status: Review Needed. Possible solution submitted labels May 31, 2019
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@effone @lairdshaw
Fixes mybb#3666 PM search - incorrect folder (mybb#3668)
5fd089d 
[Rebased for 1.9 by Laird]

* Search result folder reset

* Omit Unread in advanced search form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction t:regression Type: Regression. Degraded functionality after update
Projects
None yet
Milestone
1.8.21
Development

Successfully merging a pull request may close this issue.

Fixes #3666 PM search - incorrect folder effone/mybb
4 participants
@euantorano @dvz @MinusPL @effone