Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard coded values in ACP #3739

Closed
Eldenroot opened this issue Jun 27, 2019 · 0 comments · Fixed by #3780
Closed

Replace hard coded values in ACP #3739

Eldenroot opened this issue Jun 27, 2019 · 0 comments · Fixed by #3780
Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:resolved Status: Resolved. Solution implemented or scheduled t:code-quality Type: Code Quality. Improves code without affecting functionality
Milestone
1.8.22

Comments

@Eldenroot
Copy link
Contributor

https://community.mybb.com/thread-223612.html
Eldenroot added a commit to Eldenroot/mybb that referenced this issue Jun 27, 2019
@Eldenroot
Fixes mybb#3739 - replace hard coded values in ACP
2c4c87d 
mybb#3739
@Eldenroot Eldenroot mentioned this issue Jun 27, 2019
Merged
@effone effone added b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference t:code-quality Type: Code Quality. Improves code without affecting functionality s:review-needed Status: Review Needed. Possible solution submitted labels Jun 29, 2019
@euantorano euantorano added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:review-needed Status: Review Needed. Possible solution submitted labels Jul 21, 2019
@euantorano euantorano added this to the 1.8.22 milestone Jul 21, 2019
yuliu added a commit to yuliu/mybb-mybb that referenced this issue Aug 28, 2019
@yuliu
Fix errors of calling undefined Form objects in pull mybb#3740 that f…
76343e4 
…ixes mybb#3739.
@yuliu yuliu mentioned this issue Aug 28, 2019
Merged
euantorano pushed a commit that referenced this issue Aug 31, 2019
@yuliu @euantorano
Fix errors in pull #3740 calling undefined Form objects (#3780)
c822143 
* Fix errors of calling undefined `Form` objects in pull #3740 that fixes #3739.

* Update PHPDoc for added parameter.
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@Eldenroot @lairdshaw
Fixes mybb#3739 - replace hard coded values in ACP (mybb#3740)
a558d2f 
* Fixes mybb#3739 - replace hard coded values in ACP

mybb#3739

* Part 2

* One more .)

* Update groups.php

* Update management.php

* Update groups.php

* Update management.php
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@yuliu @lairdshaw
Fix errors in pull mybb#3740 calling undefined Form objects (mybb#3780
935c9f9 
)

* Fix errors of calling undefined `Form` objects in pull mybb#3740 that fixes mybb#3739.

* Update PHPDoc for added parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:resolved Status: Resolved. Solution implemented or scheduled t:code-quality Type: Code Quality. Improves code without affecting functionality
Projects
None yet
Milestone
1.8.22
Development

Successfully merging a pull request may close this issue.

Fix errors in pull #3740 calling undefined Form objects yuliu/mybb-mybb
3 participants
@euantorano @Eldenroot @effone