Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment code isn't stripped off post previews #4044

Closed
Ben-MyBB opened this issue Jun 2, 2020 · 0 comments · Fixed by #4050
Closed

Attachment code isn't stripped off post previews #4044

Ben-MyBB opened this issue Jun 2, 2020 · 0 comments · Fixed by #4050
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.23

Comments

@Ben-MyBB
Copy link
Member

Ben-MyBB commented Jun 2, 2020

When searching for posts a small preview of its content is displayed to the user within the search.php file but the [attachment=n] code isn't removed.

I think it should be removed.

Original thread: Attachment code isn't stripped off post previews
@Ben-MyBB Ben-MyBB added b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction labels Jun 2, 2020
JordanMussi added a commit to JordanMussi/MyBB that referenced this issue Jun 5, 2020
@JordanMussi
Fixes mybb#4044 Attachment code isn't stripped off post previews
1f2b424
@JordanMussi JordanMussi mentioned this issue Jun 5, 2020
Merged
@Ben-MyBB Ben-MyBB added s:review-needed Status: Review Needed. Possible solution submitted and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Jun 5, 2020
euantorano pushed a commit that referenced this issue Jun 6, 2020
@JordanMussi
Fixes #4044 Attachment code isn't stripped off post previews (#4050)
7ebf3b9
@euantorano euantorano added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:review-needed Status: Review Needed. Possible solution submitted labels Jun 6, 2020
@euantorano euantorano added this to the 1.8.23 milestone Jun 6, 2020
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@JordanMussi @lairdshaw
Fixes mybb#4044 Attachment code isn't stripped off post previews (myb…
2251234 
…b#4050)

[Rebased for 1.9 by Laird]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.23
Development

Successfully merging a pull request may close this issue.

Fixes #4044 Attachment code isn't stripped off post previews JordanMussi/MyBB
2 participants
@euantorano @Ben-MyBB