Moderation Notifications

[Sama34]

The following has been accepted:

• Suspension Notices to Members
• Awaiting Activation Count
• Moderation Notice

[DiogoParrinha]

@PaulBender I've assigned this issue to @Sama34 as you've got quite some work already.

[DiogoParrinha]

Postponed to Beta 3.

[Sama34]

I decided to go with one simple method for "Awaiting Activation Count". I think it will be enough.

This should be finished now.

[xykul]

No waiting for activation.
In the header "There are 50 accounts awaiting activation. Please go to your ACP to activate the users." appears.

I think this line of code. Does not count.
$cache->update('awaitingactivation', 50);

[Destroy666x]

I can confirm what xykul said.

[Sama34]

That should do it.

[xykul]

There is an error.

Replace the deleted line 681 instead of
$cache->update_awaitingactivation();

line 687
$awaitingusers = '';

line 694
if($awaitingusers > '')

in this way improved...

[Sama34]

There you go.

[xykul]

Without this code does not work.
$cache->update_awaitingactivation();

[Sama34]

@xykul Why not? If you check the commits $cache->update_awaitingactivation(); should only run when users are inserted/updated/removed from the DB to refresh the cache. It also runs during installation and upgrade as it should.

If you are experiencing issues within within your installation you should go to ACP -> Tools & Maintenance -> Cache Manager -> awaitingactivation -> Rebuild Cache.

Try registering a new user and you will see it works.

Running $cache->update_awaitingactivation(); in global.php makes no sense.

[xykul]

I made zero still does not work.
Code integrity must be so for me.
lines 684, 685, 686

    $cache->update_awaitingactivation();
    $awaitingusers = $cache->read('awaitingactivation');
    if(empty($awaitingusers))

[Sama34]

That is because the read() method users my_unserialize() instead of unserialize(). Hum.

Thanks.

[xykul]

It's working. But ACP error appears.

Warning [2] explode() expects parameter 2 to be string, array given - Line: 4746 - File: C:\wamp\www\alpha18\inc\functions.php PHP 5.5.12 (WINNT)
C:\wamp\www\alpha18\inc\functions.php   4746    explode
C:\wamp\www\alpha18\admin\modules\home\index.php    201     my_number_format
C:\wamp\www\alpha18\admin\index.php     613     require

admin\modules\home\index.php
line 195
if(empty($awaitingusers)) to if(!empty($awaitingusers))

Request : It better be the setting for the header view.

[JordanMussi]

@Sama34 ^

[Sama34]

Thanks @xykul.