Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderation Notifications #430

Closed
Sama34 opened this issue Apr 28, 2014 · 15 comments
Closed

Moderation Notifications #430

Sama34 opened this issue Apr 28, 2014 · 15 comments
Assignees
Milestone

Comments

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Apr 28, 2014

@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Apr 28, 2014
@Sama34 Sama34 self-assigned this Apr 28, 2014
@Sama34 Sama34 changed the title Suspension Notices to Members Moderation Notifications Apr 28, 2014
@Sama34 Sama34 assigned PaulBender and unassigned Sama34 May 19, 2014
@DiogoParrinha DiogoParrinha assigned Sama34 and unassigned PaulBender Jun 24, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

@PaulBender I've assigned this issue to @Sama34 as you've got quite some work already.

@DiogoParrinha DiogoParrinha modified the milestones: 1.8 Beta 3, 1.8 Beta 2 Jun 27, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 27, 2014

Postponed to Beta 3.

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

I decided to go with one simple method for "Awaiting Activation Count". I think it will be enough.

This should be finished now.

@Sama34 Sama34 added fixed labels Jul 19, 2014
Sama34 pushed a commit that referenced this issue Jul 19, 2014
@xykul
Copy link

@xykul xykul commented Jul 19, 2014

No waiting for activation.
In the header "There are 50 accounts awaiting activation. Please go to your ACP to activate the users." appears.

I think this line of code. Does not count.
$cache->update('awaitingactivation', 50);

@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Jul 19, 2014

I can confirm what xykul said.

Sama34 pushed a commit that referenced this issue Jul 19, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

That should do it.

@JordanMussi JordanMussi removed the feedback label Jul 19, 2014
@xykul
Copy link

@xykul xykul commented Jul 19, 2014

There is an error.
error

Replace the deleted line 681 instead of
$cache->update_awaitingactivation();

line 687
$awaitingusers = '';

line 694
if($awaitingusers > '')

in this way improved...

Sama34 pushed a commit that referenced this issue Jul 19, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

There you go.

@xykul
Copy link

@xykul xykul commented Jul 19, 2014

Without this code does not work.
$cache->update_awaitingactivation();

@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

@xykul Why not? If you check the commits $cache->update_awaitingactivation(); should only run when users are inserted/updated/removed from the DB to refresh the cache. It also runs during installation and upgrade as it should.

If you are experiencing issues within within your installation you should go to ACP -> Tools & Maintenance -> Cache Manager -> awaitingactivation -> Rebuild Cache.

Try registering a new user and you will see it works.

Running $cache->update_awaitingactivation(); in global.php makes no sense.

@xykul
Copy link

@xykul xykul commented Jul 20, 2014

I made zero still does not work.
Code integrity must be so for me.
lines 684, 685, 686

    $cache->update_awaitingactivation();
    $awaitingusers = $cache->read('awaitingactivation');
    if(empty($awaitingusers))
Sama34 pushed a commit that referenced this issue Jul 20, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 20, 2014

That is because the read() method users my_unserialize() instead of unserialize(). Hum.

Thanks.

@Sama34 Sama34 closed this Jul 20, 2014
@xykul
Copy link

@xykul xykul commented Jul 20, 2014

It's working. But ACP error appears.

Warning [2] explode() expects parameter 2 to be string, array given - Line: 4746 - File: C:\wamp\www\alpha18\inc\functions.php PHP 5.5.12 (WINNT)
C:\wamp\www\alpha18\inc\functions.php   4746    explode
C:\wamp\www\alpha18\admin\modules\home\index.php    201     my_number_format
C:\wamp\www\alpha18\admin\index.php     613     require

admin\modules\home\index.php
line 195
if(empty($awaitingusers)) to if(!empty($awaitingusers))

Request : It better be the setting for the header view.

@JordanMussi JordanMussi added feedback and removed fixed labels Jul 20, 2014
@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jul 20, 2014

@JordanMussi JordanMussi reopened this Jul 20, 2014
Sama34 pushed a commit that referenced this issue Jul 20, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 20, 2014

Thanks @xykul.

@Sama34 Sama34 closed this Jul 20, 2014
@DiogoParrinha DiogoParrinha added fixed and removed feedback labels Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.