Report Center #556

Closed
PirataNervo opened this Issue May 27, 2014 · 23 comments

Comments

Projects
None yet
5 participants
@PirataNervo
Contributor

PirataNervo commented May 27, 2014

Original issue on 1.8 private repo: https://github.com/mybb/MyBB18/issues/36
What needs to be done: check if it's been finished or not.

To quote:

There are currently suggestions to group together reports (and prevent 'duplicate' reports for the same post), being able to report a profile and being able to report a profile comment.

To meet these suggestions, a Report Center should be added to replace Reported Posts. This is, in fact, a 2.0 feature (see mock ups) that will be brought forward into 1.8; albeit, in a lesser form. In 1.8, the Report Center will track Posts, Profiles and Reputation Comments. It will prevent users being able to report content that has already been reported before; instead, it will simply add an extra 'vote' to the content's original report. It should not allow commenting on the report itself and relatively keep the same database schema.

We should also add specific categories for reasons for reporting content; Spam, Breaks Forum Rules, Wrong Forum and Inappropriate Content (maybe 'Other' too?). Users should be able to add more via the ACP (so a new setting will be needed). Translations of this setting's options should also be made available to handle multiple locales.

@PirataNervo PirataNervo added the 1.8 label May 27, 2014

@PirataNervo PirataNervo added this to the 1.8 Beta 1 milestone May 27, 2014

@PirataNervo PirataNervo added enhancement and removed enhancement labels May 27, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

We should rename the pid, tid and fid columns in the reportedposts table to something a little more generic (like id, id2 and id3). We have a $db->rename_column option for that very purpose...

Member

PaulBender commented May 27, 2014

We should rename the pid, tid and fid columns in the reportedposts table to something a little more generic (like id, id2 and id3). We have a $db->rename_column option for that very purpose...

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

Why? Aren't they pid's, tid's and fid's ?

Contributor

PirataNervo commented May 27, 2014

Why? Aren't they pid's, tid's and fid's ?

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

Not if you report a reputation or a profile

Member

PaulBender commented May 27, 2014

Not if you report a reputation or a profile

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

That is right - I'm not too much into this feature as you know - but isn't there a 'uid' and 'rid' field for profiles and reputation reports?

Contributor

PirataNervo commented May 27, 2014

That is right - I'm not too much into this feature as you know - but isn't there a 'uid' and 'rid' field for profiles and reputation reports?

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

No, they're inserted to the pid, tid and fid columns at the moment

Member

PaulBender commented May 27, 2014

No, they're inserted to the pid, tid and fid columns at the moment

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

Well then your assumption is right, we should definitely rename them.

Contributor

PirataNervo commented May 27, 2014

Well then your assumption is right, we should definitely rename them.

PaulBender added a commit that referenced this issue May 27, 2014

Working on #556 Report Center
Renamed pid, tid and fid columns to id, id2 and id3
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

Done.

Maybe we should rename the table while we're at it. Maybe something like reportedcontent

Member

PaulBender commented May 27, 2014

Done.

Maybe we should rename the table while we're at it. Maybe something like reportedcontent

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

Have you tested the upgrade? The table renaming sounds good to but I'm not sure if we have a routine to do it - and I'm not sure if query's syntax is the same across the different database engines we support.

Contributor

PirataNervo commented May 27, 2014

Have you tested the upgrade? The table renaming sounds good to but I'm not sure if we have a routine to do it - and I'm not sure if query's syntax is the same across the different database engines we support.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

Yes, I've tested the upgrade routine and it came out perfect. This includes the table renaming.

As for renaming the table, I can add a routine to do it, the syntax is simple for all database types.

Member

PaulBender commented May 27, 2014

Yes, I've tested the upgrade routine and it came out perfect. This includes the table renaming.

As for renaming the table, I can add a routine to do it, the syntax is simple for all database types.

PaulBender added a commit that referenced this issue May 27, 2014

Working on #556 Report Center
Updated the column name in a few places I missed previously
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

This commit updates a few places I missed in my last commit. It also updates them to work with the current report center design.

Member

PaulBender commented May 27, 2014

This commit updates a few places I missed in my last commit. It also updates them to work with the current report center design.

PaulBender added a commit that referenced this issue May 27, 2014

Working on #556 Report Center
Added $db->rename_table routine
Renamed reportedposts table to reportedcontent
Renamed reportedposts cache to reportedcontent
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 27, 2014

Member

This commit changes several things. First it adds a $db->rename_table routine, allowing you to change the name of a table easily.

Second, it changes the name of the reportedposts table to reportedcontent.

Third it renames the reportedposts cache to reportedcontent (found the first use of the new $cache->delete method).

Member

PaulBender commented May 27, 2014

This commit changes several things. First it adds a $db->rename_table routine, allowing you to change the name of a table easily.

Second, it changes the name of the reportedposts table to reportedcontent.

Third it renames the reportedposts cache to reportedcontent (found the first use of the new $cache->delete method).

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 27, 2014

Contributor

Sounds good :) Needs some testing by SQA though.

Contributor

PirataNervo commented May 27, 2014

Sounds good :) Needs some testing by SQA though.

PaulBender added a commit that referenced this issue May 28, 2014

Working on #556 Report Center
Just a few things I missed
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

This commit fixed one last column rename I spotted just now.

Member

PaulBender commented May 28, 2014

This commit fixed one last column rename I spotted just now.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

What else needs to be done here?

Contributor

PirataNervo commented May 28, 2014

What else needs to be done here?

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Nothing I know of.

Maybe add a few hooks so plugin authors can expand the report center.

Member

PaulBender commented May 28, 2014

Nothing I know of.

Maybe add a few hooks so plugin authors can expand the report center.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

Feel free to add hooks where you think they are necessary and then you can close this :)

Contributor

PirataNervo commented May 28, 2014

Feel free to add hooks where you think they are necessary and then you can close this :)

PaulBender added a commit that referenced this issue May 28, 2014

Working on #556 Report Center
Added plugin hooks in report.php
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Added some hooks in report.php. Mod CP hooks look fine.

Closing this.

Member

PaulBender commented May 28, 2014

Added some hooks in report.php. Mod CP hooks look fine.

Closing this.

@PaulBender PaulBender closed this May 28, 2014

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #556 Report Center
Renamed pid, tid and fid columns to id, id2 and id3

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #556 Report Center
Updated the column name in a few places I missed previously

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #556 Report Center
Added $db->rename_table routine
Renamed reportedposts table to reportedcontent
Renamed reportedposts cache to reportedcontent

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #556 Report Center
Just a few things I missed

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #556 Report Center
Added plugin hooks in report.php
@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul May 30, 2014

This error is normal?
1.7 upgrade, 1.6.13 marked and error ..

MyBB SQL Error

MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1146 - Table 'alpha18.mybb_reportedposts' doesn't exist
Query:
SHOW COLUMNS FROM mybb_reportedposts LIKE 'type'

Please contact the MyBB Group for technical support.

xykul commented May 30, 2014

This error is normal?
1.7 upgrade, 1.6.13 marked and error ..

MyBB SQL Error

MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1146 - Table 'alpha18.mybb_reportedposts' doesn't exist
Query:
SHOW COLUMNS FROM mybb_reportedposts LIKE 'type'

Please contact the MyBB Group for technical support.

@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST May 30, 2014

Contributor

@xykul No, however I haven't experienced any similar issue yet.

Contributor

Stefan-ST commented May 30, 2014

@xykul No, however I haven't experienced any similar issue yet.

@Polarbear541

This comment has been minimized.

Show comment
Hide comment
@Polarbear541

Polarbear541 May 30, 2014

Contributor

@xykul Have you re-installed/re-run the upgrader as these commits change the DB table names?

Contributor

Polarbear541 commented May 30, 2014

@xykul Have you re-installed/re-run the upgrader as these commits change the DB table names?

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul May 30, 2014

1.7 new installation, upgrade
error

xykul commented May 30, 2014

1.7 new installation, upgrade
error

@Polarbear541

This comment has been minimized.

Show comment
Hide comment
@Polarbear541

Polarbear541 May 30, 2014

Contributor

And you're definitely running the latest code from the feature branch?

Contributor

Polarbear541 commented May 30, 2014

And you're definitely running the latest code from the feature branch?

@Stefan-ST

This comment has been minimized.

Show comment
Hide comment
@Stefan-ST

Stefan-ST May 30, 2014

Contributor

mybb_reportedposts is a table that exists in MyBB 1.6. If it's missing your existing database may be broken.

Contributor

Stefan-ST commented May 30, 2014

mybb_reportedposts is a table that exists in MyBB 1.6. If it's missing your existing database may be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment