Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP Banning Improvements v2 #628

Closed
DiogoParrinha opened this issue May 29, 2014 · 6 comments
Closed

ACP Banning Improvements v2 #628

DiogoParrinha opened this issue May 29, 2014 · 6 comments

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented May 29, 2014

Related to #554 - this is what's left to do:

  • Add the ability to search for a user from the ACP Banning page (instead of just assuming you want to ban a user).
  • Users in banned group shouldn't be able to be banned manually.
@dragonexpert
Copy link
Contributor

@dragonexpert dragonexpert commented May 30, 2014

Shouldn't it also be searchable from the Mod CP? I also would like to propose that bans can sorted by username, date banned, date lifted.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented May 31, 2014

This is specifically for ACP improvements. If we agree that ModCP also needs improvements a new issue should be created.

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented May 31, 2014

No sure if this is the place to suggest this, but you shouldn't be able to add users from a banned group to the banned list.

This is possible, for example, if you move an user to a banned group, you can still ban it.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

@Sama34 makes sense; added to list.

DiogoParrinha pushed a commit that referenced this issue Jun 28, 2014
WIP #628 ACP Banning Improvements v2
DiogoParrinha pushed a commit that referenced this issue Jun 28, 2014
WIP #628 ACP Banning Improvements v2
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

This is now finished.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 29, 2014

Closing this, no issues found so far, ETA is closing in.

@DiogoParrinha DiogoParrinha removed the feedback label Jun 29, 2014
@DiogoParrinha DiogoParrinha removed their assignment Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.