Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to smilies #905

Closed
Sama34 opened this issue Jul 8, 2014 · 6 comments
Closed

Add class to smilies #905

Sama34 opened this issue Jul 8, 2014 · 6 comments
Assignees
Milestone

Comments

@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jul 8, 2014

We should add a class to each smiles (based off the smile ID) so that administrators can style them as they please.

Reference: http://community.mybb.com/thread-155775.html

@Sama34 Sama34 added this to the 1.8 Beta 3 milestone Jul 8, 2014
@Sama34 Sama34 self-assigned this Jul 8, 2014
Sama34 pushed a commit that referenced this issue Jul 13, 2014
Sama34 pushed a commit that referenced this issue Jul 13, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 18, 2014

I guess this is finished?

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jul 18, 2014

I don't think so. The admin cannot yet add a class to a smilie (purpose of feature)...

@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Jul 18, 2014

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

But there is another problem - what's cursor: smilie_pointer;? That doesn't exist. Should be just cursor: pointer;

Perhaps also remove the outdated border="0" from smilie template since the border is removed by img CSS anyways.

@JordanMussi
Copy link
Member

@JordanMussi JordanMussi commented Jul 18, 2014

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

Stupid me... 👅

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 18, 2014

Sama34 pushed a commit that referenced this issue Jul 19, 2014
@Sama34
Copy link
Contributor Author

@Sama34 Sama34 commented Jul 19, 2014

This is finished. Please open a new issue for bugs, thanks!

@Sama34 Sama34 closed this Jul 19, 2014
@Sama34 Sama34 added the fixed label Jul 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.