New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to smilies #905

Closed
Sama34 opened this Issue Jul 8, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@Sama34
Contributor

Sama34 commented Jul 8, 2014

We should add a class to each smiles (based off the smile ID) so that administrators can style them as they please.

Reference: http://community.mybb.com/thread-155775.html

@Sama34 Sama34 added this to the 1.8 Beta 3 milestone Jul 8, 2014

@Sama34 Sama34 self-assigned this Jul 8, 2014

Sama34 pushed a commit that referenced this issue Jul 13, 2014

Sama34 pushed a commit that referenced this issue Jul 13, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 18, 2014

Contributor

I guess this is finished?

Contributor

PirataNervo commented Jul 18, 2014

I guess this is finished?

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jul 18, 2014

Contributor

I don't think so. The admin cannot yet add a class to a smilie (purpose of feature)...

Contributor

JordanMussi commented Jul 18, 2014

I don't think so. The admin cannot yet add a class to a smilie (purpose of feature)...

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 18, 2014

Contributor

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

But there is another problem - what's cursor: smilie_pointer;? That doesn't exist. Should be just cursor: pointer;

Perhaps also remove the outdated border="0" from smilie template since the border is removed by img CSS anyways.

Contributor

Destroy666x commented Jul 18, 2014

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

But there is another problem - what's cursor: smilie_pointer;? That doesn't exist. Should be just cursor: pointer;

Perhaps also remove the outdated border="0" from smilie template since the border is removed by img CSS anyways.

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jul 18, 2014

Contributor

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

Stupid me... 👅

Contributor

JordanMussi commented Jul 18, 2014

They can - there is smilie class for every smilie and smilie_X where X is the Smilie ID for single smilies.

Stupid me... 👅

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo
Contributor

PirataNervo commented Jul 18, 2014

Sama34 pushed a commit that referenced this issue Jul 19, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 19, 2014

Contributor

This is finished. Please open a new issue for bugs, thanks!

Contributor

Sama34 commented Jul 19, 2014

This is finished. Please open a new issue for bugs, thanks!

@Sama34 Sama34 closed this Jul 19, 2014

@Sama34 Sama34 added the fixed label Jul 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment