Fix #1913 Database export should ignore views #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The MySQL solution seems to be ok (haven't tested yet though), but what about PgSQL/SQLite? Both support views AFAIK. SQLite code seems to get only the |
|
|
Looks good to me, thanks! |
euantorano
added a commit
that referenced
this pull request
Jun 23, 2015
Fix #1913 Database export should ignore views
|
Missed the reply:
You're right, didn't notice it earlier somehow, I think github showed a blank 1st comment for some reason. Anyways, I can confirmt it works too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affected MySQL and MySQLi.
SQLite implementation already specifies tables only.
PostgreSQL doesn't include the views in information_schema.tables anyway.