Fixes #2299 - Missing setting descriptions in ACP #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2299 - Missing setting desctriptions in ACP
Eldenroot
changed the title
|
@Ben-Conway can you take a first look at this? |
Shade-
suggested changes
Dec 4, 2016
| <disporder>1</disporder> | ||
| <optionscode><![CDATA[yesno]]></optionscode> | ||
| <settingvalue><![CDATA[1]]></settingvalue> | ||
| <isdefault>1</isdefault> | ||
| </setting> | ||
| <setting name="maxattachments"> | ||
| <title>Maximum Attachments Per Post</title> | ||
| <description><![CDATA[The maximum number of attachments a user is allowed to upload per post.]]></description> | ||
| <description><![CDATA[The maximum number of attachments a user is allowed to upload per post. Set to 0 disable.]]></description> |
There was a problem hiding this comment.
"Set to 0 disable." --> "Set to 0 to disable."
|
This looks good, except for the aforementioned part for which I requested a change. Note that I've only checked the diff report, some other descriptions may require editing with the "Set to 0 to disable" notice. Btw, +1 to @Cu8eeeR for standardizing the Yes/No labels. |
|
@Shade- thank you! I fixed the typo you mentioned above. It would be really nice if someone can look at this and find other places where the change is needed. |
Shade-
approved these changes
Dec 4, 2016
|
Looks good to me. I had a quick glance and didn't notice anywhere else needing this change. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2299 - Missing setting desctriptions in ACP
@JN-Jones @PaulBender @Destroy666x @dequeues
I am not sure about these: setting in L around n. 217 and 1411
Please review it carefully, I will try my best to find them all and fix the missing descriptions.