Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3304 - conditional sepator #3305

Merged

Conversation

euantorano
Copy link
Member

@euantorano euantorano commented Jul 5, 2018

Fixes #3304 The separator is moved into a language variable and the templates including the separator are updated.

The separator is moved into a language variable and the templates including the separator are updated.

Signed-off-by: Euan Torano <euantorano@gmail.com>
@euantorano euantorano force-pushed the fix-redundant-|-next-to-forum-team branch from 2fe87d4 to 7722fff Compare July 5, 2018 18:35
@euantorano euantorano added the b:1.8 Branch: 1.8.x label Jul 5, 2018
@Eldenroot
Copy link
Contributor

Will be there a hotfix (1.8.16) or a new release with 10 issues fixed (according to the milestone?). Because because of that it would require bumt the template version to 1817.

About this PR, works fine.

@euantorano
Copy link
Member Author

euantorano commented Jul 5, 2018

It'll be a 1.8.17 release as handling patched packages is not fun for anybody involved.

Signed-off-by: Euan Torano <euantorano@gmail.com>
@euantorano
Copy link
Member Author

Version numbers of templates in this PR bumped.

@euantorano euantorano merged commit 517139d into mybb:feature Jul 6, 2018
@euantorano euantorano deleted the fix-redundant-|-next-to-forum-team branch July 6, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants