Fixed send_mail_queue call #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We’ve had a few reports of mails not sending... this could be the cause :P
… On 30 Jul 2018, at 17:47, zygzagZ ***@***.***> wrote:
In inc/init.php:243 there is function call that registers send_mail_queue to be run at shutdown.
add_shutdown('send_mail_queue');
But just after include init.php in global.php, shutdown_functions is erased, not allowing send_mail_queue to run.
`// Load main MyBB core file which begins all of the magic
require_once $working_dir.'/inc/init.php';
$shutdown_queries = $shutdown_functions = array();`
You can view, comment on, or merge this pull request online at:
#3371
Commit Summary
Fixed send_mailqueue call
moved comment, too
File Changes
M global.php (4)
Patch Links:
https://github.com/mybb/mybb/pull/3371.patch
https://github.com/mybb/mybb/pull/3371.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Mails are still sent when running task.php and some other files. Nonetheless this was annoying enough for me to debug it ;) |
|
Yeah, it’s definitely been an annoying one. Very glad to have a fix at last.
… On 30 Jul 2018, at 18:02, zygzagZ ***@***.***> wrote:
Mails are still sent when running task.php and some other files. Nonetheless this was annoying enough for me to debug it ;)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Created an issue for this PR for tracking purposes when it comes to release time: #3372 Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3372
In inc/init.php:243 there is function call that registers send_mail_queue to be run at shutdown.
add_shutdown('send_mail_queue');But just after
require init.phpin global.php, array$shutdown_functionsis erased, not allowing send_mail_queue to run.// Load main MyBB core file which begins all of the magicrequire_once $working_dir.'/inc/init.php';$shutdown_queries = $shutdown_functions = array();