Working on implementing SwiftMailer #3265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding a composer configuration file for the project, with no defined dependencies. * Rquire autoload file Signed-off-by: Euan Torano <euantorano@gmail.com> * Removing global.php from files to autoload
* Initial admin routing setup * Adding a basic layout for the ACP
* Starting work on moving front end to Twig This marks the start of integrating Twig into the front end. There are two global variables shared with all views - mybb and lang. Signed-off-by: Euan Torano <euantorano@gmail.com> * Starting the long process of template translation Not much to show yet, but this is a first step towards seeing that key variables such as $mybb, $lang and $theme can be accessed. Need to sort out loading of stylesheets still to make things look decent. Signed-off-by: Euan Torano <euantorano@gmail.com> * Changing how language is registered There is a new LangExtension that provides a `trans` function along with the `lang` global. Signed-off-by: Euan Torano <euantorano@gmail.com> * Showing drafts by adding drafts to an array Moved setting of theme global to theme extension. Need to fix the use of |raw in some places - we should generate the HTML inside the views themselves instead… Signed-off-by: Euan Torano <euantorano@gmail.com> * Finished the majority of work on the drafts page Signed-off-by: Euan Torano <euantorano@gmail.com> * Add return type hints Signed-off-by: Euan Torano <euantorano@gmail.com> * Fixing trow usage currently following 1.8 standard Signed-off-by: Euan Torano <euantorano@gmail.com>
mybb#2975) * Working on mybb#2972 Template Conversion to Twig Format (warnings.php) Part 1 - User warning log * Coding standards * Working on mybb#2972 Template Conversion to Twig Format (warnings.php) Part 2 - Warning details * Working on mybb#2972 Template Conversion to Twig Format (warnings.php) Part 3 - Warning a user
* Starting work on translatig subscribed threads Signed-off-by: Euan Torano <euantorano@gmail.com> * Finish subscriptions page in UCP Signed-off-by: Euan Torano <euantorano@gmail.com> * Use `&` rather than `&` in URL. Signed-off-by: Euan Torano <euantorano@gmail.com> * Move HTML out of PHP into view Also use `threadprefix` as `raw` as it can contain HTML.
mybb#2984) * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 1 - Adding an event * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 2 - Editing an event * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 3 - Moving event * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 4 - Viewing an event * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 5 - Day view * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 6 - Week view * Working on mybb#2972 Template Conversion to Twig Format (calendar.php) Part 7 - Calendar * Moved gobutton to inline * Code updates -Added selected and checked HTML to templates -Move day select options to array * More code updates - Moved month select options to array - Split bottom calendar jump/month jump into seperate Twig file - Converted user stars to Twig
…ing on PHP 7.2 (mybb#2995) * [FIX] string to array conversation causing Illegal string offset warning on PHP 7.2 * Use 4 spaces instead of tab
Signed-off-by: Euan Torano <euantorano@gmail.com>
…mybb#2991) * Working on mybb#2972 Template Conversion to Twig Format (contact.php) * Indented template
* Postbit — For mybb#2972 [WIP] * removed horizontal postbit * postbit_groupimage * postbit_userstar * Online Status postbit_online, postbit_away. postbit_offline * postbit_avatar * postbit_find * postbit_pm * postbit_rep_button * postbit_www * postbit_email * User Details postbit_author_user, postbit_author_guest * postbit_reputation * Warning Info postbit_warninglevel, postbit_warn * postbit_purgespammer * Custom Profile Fields postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value * Private Messages postbit_reply_pm, postbit_replyall_pm, postbit_forward_pm, * Edit Message postbit_editedby, postbit_editedby_editreason * Post Edit postbit_editreason, postbit_edit * Quick Delete/Restore postbit_quickdelete, postbit_quickrestore * Post Links/Inline Moderation postbit_posturl, postbit_inlinecheck * postbit_quote * postbit_multiquote * postbit_report * Announcements announcement_edit, announcement_quickdelete * Post IP Display postbit_iplogged_show, postbit_iplogged_hiden * postbit_status * postbit_signature * postbit_icon * postbit_deleted * postbit_ignored * postbit_deleted_member * Attachments postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved * Code Cleanuo * More Code Cleanup
* Initial Cleanup and Main Template Conversion [WIP] * report_thanks * report_thanks * Errors report_error_nomodal, * report_duplicate * Report Reason report_reason, report_reasons * Separated `nomodal` Content ...and code cleanup, refactoring info sent to Twig, and fixing an error where a legacy language string was left in the `report_reasons.twig` template. * Adjust Alignment * Remove unused assignment * Remove Template Cache List
…er) (mybb#3259) * Converted modcp finduser * Removed redundant condition
…bb#3258) * Converted xmlhttp * Fixed indenting
mybb#3252) * Converted smilieinsert * Unlocked smilie inclusion * Fixed indent, moved HTML from php to twig * Minor fixes
…b#3253) * Converted footer * Added missing post_code_string * Fixed indent
…r) (mybb#3242) * Converted usercp_avatar * Fixed indenting and code style * Fixed bburl -> bbname
…bb#3249) * Converted mycodes * Deleted old parser/video.twig template * Restored onclick and extraclass for smilie template * Moved HTML from php to twig
…ns) (mybb#3243) * Converted usercp options * Converted themeselector and lang fixes to templates * Fixes indent and minor syntax change
This removes the old mail handler class and substitutes Swiftmailer for sending emails. This code is not yet tested, but I will be testing it during tomorrow. Signed-off-by: Euan Torano <euantorano@gmail.com>
euantorano
added
t:enhancement
Signed-off-by: Euan Torano <euantorano@gmail.com>
euantorano
force-pushed
the
develop/1.9-add-swiftmailer-for-mail
branch
from
c48a2c4
to
bab7b3f
Compare
Signed-off-by: Euan Torano <euantorano@gmail.com>
Signed-off-by: Euan Torano <euantorano@gmail.com>
Signed-off-by: Euan Torano <euantorano@gmail.com>
|
Two issues found:
|
effone
added
the
s:conflict
|
send_mail_queue shutdown function fixed in #3371 |
|
Yep, I just need to rebase the |
|
I can't understand, there are too many commits for this SwiftMail feature. |
|
That is due to the ongoing rebase - this PR will be recreated after the rebase is complete.
…On Fri, 24 Jul 2020, at 20:57, Rajat Jain wrote:
I can't understand, there are too many commits for this SwiftMail feature.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3265 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW24N5IPNAQNWHIBRQTVTR5HRR5ANCNFSM4FFKQRKQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2909
This removes the old mail handler class and substitutes SwiftMailer for sending emails.
This code is not yet tested, but I will be testing it during tomorrow.