-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #2070 Add new x-remote-addr var to the get_ip() function #3400
base: feature
Are you sure you want to change the base?
Conversation
The ACP settings will be created after review / confirmation for considered headers and their check sequence. |
A setting should be used as the first and only source for IP addresses, perhaps with a fallback to The actual list for attempts could be included in the installation process - see https://community.mybb.com/thread-219338.html |
$filter_headers = array( | ||
'HTTP_X_FORWARDED_FOR', | ||
'HTTP_CLIENT_IP', | ||
'HTTP_CF_CONNECTING_IP ', // Cloudflare Proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove space from the end of the string
'HTTP_CF_CONNECTING_IP ', // Cloudflare Proxy | |
'HTTP_CF_CONNECTING_IP', // Cloudflare Proxy |
@effone - will you finish this one? Thx |
Yes @Eldenroot , need to rewrite the PR, cause the approach outlined by @dvz is different from what it is now. |
@effone Ping! Reminder about this PR :) |
Failed to understand this part @dvz |
Fixed the link (https://community.mybb.com/thread-219338.html) - when the installer is rewritten, the header name can be detected automatically. |
Attempt to resolve #2070
Task List:
get_ip( )
function to handle various headers@dvz @euantorano (or some expert/s) please review the ordering in
$filter_headers
array. This is important as the first match will be considered to return.