Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #3530 Modern password hashing #3571

Merged
merged 4 commits into from
Feb 10, 2019
Merged

Resolve #3530 Modern password hashing #3571

merged 4 commits into from
Feb 10, 2019

Conversation

dvz
Copy link
Member

@dvz dvz commented Feb 5, 2019

Resolve #3530

@dvz dvz added the b:1.9 Branch: 1.9.x label Feb 5, 2019
euantorano
euantorano requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor feedback.

inc/functions_user.php Show resolved Hide resolved
inc/init.php Outdated Show resolved Hide resolved
@euantorano euantorano merged commit 01705dd into mybb:develop/1.9 Feb 10, 2019
euantorano pushed a commit to euantorano/mybb that referenced this pull request Mar 23, 2019
@dvz @euantorano
Resolve mybb#3530 Modern password hashing (mybb#3571)
cf1a43b 
* Add Illuminate\Config\Repository, load old config values

* Add internal password algorithm recognition using Illuminate\Hashing

* add PHPDoc for dynamically accessed objects

* Create basic Config service provider
euantorano pushed a commit to euantorano/mybb that referenced this pull request Mar 23, 2019
@dvz @euantorano
Resolve mybb#3530 Modern password hashing (mybb#3571)
d225830 
* Add Illuminate\Config\Repository, load old config values

* Add internal password algorithm recognition using Illuminate\Hashing

* add PHPDoc for dynamically accessed objects

* Create basic Config service provider
euantorano pushed a commit that referenced this pull request Jun 2, 2019
@dvz @euantorano
Resolve #3530 Modern password hashing (#3571)
f2b48f5 
* Add Illuminate\Config\Repository, load old config values

* Add internal password algorithm recognition using Illuminate\Hashing

* add PHPDoc for dynamically accessed objects

* Create basic Config service provider
euantorano pushed a commit that referenced this pull request Jun 2, 2019
@dvz @euantorano
Resolve #3530 Modern password hashing (#3571)
56b57a1 
* Add Illuminate\Config\Repository, load old config values

* Add internal password algorithm recognition using Illuminate\Hashing

* add PHPDoc for dynamically accessed objects

* Create basic Config service provider
@euantorano euantorano mentioned this pull request Jan 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euantorano euantorano euantorano approved these changes

Assignees
No one assigned
Labels
b:1.9 Branch: 1.9.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvz @euantorano