Fix #4209 - send the mail queue using a task that runs every minute #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te. Add a new setting to manage how many messages to send.
Ben-MyBB
approved these changes
Jan 30, 2021
|
I’ll sort the conflicts this evening.
…On Sat, 30 Jan 2021, at 15:46, Ben wrote:
***@***.**** approved this pull request.
Aside from the conflicts on this PR it all looks good. @mybb/developers
<https://github.com/orgs/mybb/teams/developers> given that I'm not
overly experienced at the minute could someone else give this a look
over please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4210 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW24P5FF5S6JTHN7EVK2DS4QSVRANCNFSM4VMN5IRA>.
|
|
Conflicts resolved. |
|
I have applied to my board, seems to be fine, if anything I will add a note here. |
Sama34
approved these changes
Feb 21, 2021
Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com>
lairdshaw
pushed a commit
to lairdshaw/mybb
that referenced
this pull request
Oct 11, 2021
…te (mybb#4210) * Fix mybb#4209 - send the mail queue using a task that runs every minute. Add a new setting to manage how many messages to send. * Fix indentation of `tasks.xml` to use spaces rather than tabs. * Update install/resources/upgrade52.php Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com> Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4209.
This adds a new task,
sendmailqueue, which defaults to running every minute.It also adds a new setting to manage the maximum number of messages to send from the mail queue when the task runs - previously only the default value of 10 emails would be used.