Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4209 - send the mail queue using a task that runs every minute #4210

Merged
merged 4 commits into from Mar 2, 2021

Conversation

euantorano
Copy link
Member

Fixes #4209.

This adds a new task, sendmailqueue, which defaults to running every minute.

It also adds a new setting to manage the maximum number of messages to send from the mail queue when the task runs - previously only the default value of 10 emails would be used.

Copy link
Member

@Ben-MyBB Ben-MyBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the conflicts on this PR it all looks good. @mybb/developers given that I'm not overly experienced at the minute could someone else give this a look over please?

@euantorano
Copy link
Member Author

euantorano commented Jan 30, 2021 via email

@euantorano
Copy link
Member Author

Conflicts resolved.

@Eldenroot
Copy link
Contributor

I have applied to my board, seems to be fine, if anything I will add a note here.

Copy link
Contributor

@Sama34 Sama34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add the suggested code to the upgrade script.

install/resources/upgrade52.php Show resolved Hide resolved
Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com>
@euantorano euantorano merged commit a16284b into mybb:feature Mar 2, 2021
@euantorano euantorano deleted the fix/4209-mailqueue-task branch March 2, 2021 12:10
lairdshaw pushed a commit to lairdshaw/mybb that referenced this pull request Oct 11, 2021
…te (mybb#4210)

* Fix mybb#4209 - send the mail queue using a task that runs every minute. Add a new setting to manage how many messages to send.

* Fix indentation of `tasks.xml` to use spaces rather than tabs.

* Update install/resources/upgrade52.php

Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com>

Co-authored-by: Omar Gonzalez <Sama34@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move mail queue processing to a task rather than a shutdown function
4 participants