make assertValidValue private as it's not valuable to extend the API.…

… One can programatically call `isValid()` returning bool or just create a new instance with `from()` throwing exception
myclabs · Feb 14, 2021 · bbd35d0 · bbd35d0
1 parent 8d8c6ec
commit bbd35d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/src/Enum.php b/src/Enum.php
@@ -198,7 +198,7 @@ public static function isValid($value)
      * @psalm-pure
      * @psalm-assert T $value
      */
-    public static function assertValidValue($value): void
+    private static function assertValidValue($value): void
     {
         if (!static::isValid($value)) {
             throw new \UnexpectedValueException("Value '$value' is not part of the enum " . static::class);

diff --git a/tests/EnumTest.php b/tests/EnumTest.php
@@ -60,6 +60,14 @@ public function testFailToCreateEnumWithInvalidValueThroughNamedConstructor($val
         EnumFixture::from($value);
     }
 
+    public function testFailToCreateEnumWithEnumItselfThroughNamedConstructor(): void
+    {
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage("Value 'foo' is not part of the enum " . EnumFixture::class);
+
+        EnumFixture::from(EnumFixture::FOO());
+    }
+
     /**
      * Contains values not existing in EnumFixture
      * @return array
@@ -345,18 +353,4 @@ public function testEnumValuesInheritance()
         new EnumFixture($inheritedEnumFixture);
     }
 
-    /**
-     * @dataProvider isValidProvider
-     */
-    public function testAssertValidValue($value, $isValid): void
-    {
-        if (!$isValid) {
-            $this->expectException(\UnexpectedValueException::class);
-            $this->expectExceptionMessage("Value '$value' is not part of the enum " . EnumFixture::class);
-        }
-
-        EnumFixture::assertValidValue($value);
-
-        self::assertTrue(EnumFixture::isValid($value));
-    }
 }