Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple scene operations #17

Merged
merged 31 commits into from
Jun 28, 2023
Merged

feat: add support for multiple scene operations #17

merged 31 commits into from
Jun 28, 2023

Conversation

joaoborks
Copy link
Member

Closes #16

@joaoborks
build: update Unity to 2022.2.12f1
ddf51e0
@joaoborks
refactor: add default parameter values to loaders
58f47d9
@joaoborks
fix: remove unitask reference from coroutine loader
5a9c1e4
@joaoborks
add script-templates package
0c5f975
@joaoborks
feat: add interface support for multiple scene ops
ec7c769
@joaoborks
feat: add batch scene operations for scene manager
e917354
@joaoborks
build: update to Unity 2022.2.17f1
e749b99
@joaoborks
feat: add batch scene operation tests
653da22
@joaoborks
feat: add addressable batch scene operations
a4f10de
@joaoborks
refactor: improve debug messages
90ef366
@joaoborks
docs: add docs for ISceneManager batch operations
90b62a9
@joaoborks
feat: add batch scene ops to scene loader interface
b3a4652
@joaoborks
refactor: simplify regular scene operations
a7304b5
@joaoborks
feat: add async scene loader batch scene operations
da93e7b
@joaoborks
test: add scene loader batch scene ops tests
320eb42
@joaoborks
refactor: minor tweaks and improvements
e89967a
@joaoborks joaoborks self-assigned this May 5, 2023
@joaoborks joaoborks linked an issue May 5, 2023 that may be closed by this pull request
Add support for multiple scene operations #16
Closed
@joaoborks joaoborks force-pushed the 16-add-support-for-multiple-scene-operations branch from ace4ea5 to 0bbbd20 Compare May 5, 2023 04:36
@joaoborks
Copy link
Member Author

Some tests are randomly throwing the error:

Unhandled log message: '[Assert] Assertion failed on expression: '!(GetPersistentManager().IsStreamLoaded(pathName) && !GetPersistentManager().HasMemoryOrCachedSerializedFile(pathName))''. Use UnityEngine.TestTools.LogAssert.Expect

@joaoborks joaoborks force-pushed the 16-add-support-for-multiple-scene-operations branch from d7f0314 to e1c0c5f Compare May 6, 2023 00:52
@joaoborks
Copy link
Member Author

I've found this forum post, but it's applied to a different context. I tried to wait a frame between tests, but that still didn't help.

@joaoborks
Copy link
Member Author

Some tests are randomly throwing the error:

Unhandled log message: '[Assert] Assertion failed on expression: '!(GetPersistentManager().IsStreamLoaded(pathName) && !GetPersistentManager().HasMemoryOrCachedSerializedFile(pathName))''. Use UnityEngine.TestTools.LogAssert.Expect

A public issue has been created with this error. I guess now we have to vote for it and wait for it to be fixed.

@joaoborks
Copy link
Member Author

I had an idea. Instead of waiting for Unity to fix the issue on their side, I can just hardcode a windows image to be used for the tests, since the issue is not reproducible on windows machines. Once the issue is fixed, I can revert this manual change.

@joaoborks joaoborks mentioned this pull request Jun 27, 2023
Closed
@joaoborks joaoborks changed the title Add support for multiple scene operations feat: add support for multiple scene operations Jun 28, 2023
@joaoborks joaoborks merged commit 87117e0 into main Jun 28, 2023
2 checks passed
@joaoborks joaoborks deleted the 16-add-support-for-multiple-scene-operations branch June 28, 2023 14:23
joaoborks pushed a commit that referenced this pull request Jun 28, 2023
@semantic-release-bot
ci(release): 2.2.0 [skip ci]
3493db4 
# [2.2.0](2.1.1...2.2.0) (2023-06-28)

### Features

* add support for multiple scene operations ([#17](#17)) ([87117e0](87117e0))
@joaoborks
Copy link
Member Author

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
@semantic-release-bot
ci(release): 2.2.0 [skip ci]
3e4664d 
# [2.2.0](2.1.1...2.2.0) (2023-06-28)

### Features

* add support for multiple scene operations ([#17](#17)) ([87117e0](87117e0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaoborks joaoborks

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple scene operations
1 participant
@joaoborks