Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yamllint): add rule empty-values & use new yaml-files setting #27

Merged
merged 4 commits into from
Sep 12, 2019
Merged

feat(yamllint): add rule empty-values & use new yaml-files setting #27

merged 4 commits into from
Sep 12, 2019

Conversation

myii
Copy link
Owner

@myii myii commented Sep 9, 2019

myii added a commit to myii/apt-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
3e103fb 
* Automated using myii/ssf-formula#27
myii added a commit to myii/iptables-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
8731889 
* Automated using myii/ssf-formula#27
myii added a commit to myii/sysctl-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
ece4628 
* Automated using myii/ssf-formula#27
myii added a commit to myii/locale-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
7475383 
* Automated using myii/ssf-formula#27
myii added a commit to myii/keepalived-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
0273351 
* Automated using myii/ssf-formula#27
myii added a commit to myii/collectd-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
4449d8f 
* Automated using myii/ssf-formula#27
myii added a commit to myii/vim-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
0106aaf 
* Automated using myii/ssf-formula#27
myii added a commit to myii/golang-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
4d5d128 
* Automated using myii/ssf-formula#27
myii added a commit to myii/vsftpd-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
b5215b5 
* Automated using myii/ssf-formula#27
myii added a commit to myii/logrotate-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
cc01df5 
* Automated using myii/ssf-formula#27
myii added a commit to myii/fail2ban-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
62c3143 
* Automated using myii/ssf-formula#27
myii added a commit to myii/dhcpd-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
8fd7616 
* Automated using myii/ssf-formula#27
myii added a commit to myii/mysql-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
1859457 
* Automated using myii/ssf-formula#27
myii added a commit to myii/timezone-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
23af056 
* Automated using myii/ssf-formula#27
myii added a commit to myii/rkhunter-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
e6064eb 
* Automated using myii/ssf-formula#27
myii added a commit to myii/php-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
6aba5fd 
* Automated using myii/ssf-formula#27
myii added a commit to myii/users-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
c1a4f9e 
* Automated using myii/ssf-formula#27
myii added a commit to myii/systemd-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
1532369 
* Automated using myii/ssf-formula#27
myii added a commit to myii/syslog-ng-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
4cb3295 
* Automated using myii/ssf-formula#27
myii added a commit to myii/grafana-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
8233ccd 
* Automated using myii/ssf-formula#27
myii added a commit to myii/openvpn-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
fc50647 
* Automated using myii/ssf-formula#27
myii added a commit to myii/deepsea-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
6132c78 
* Automated using myii/ssf-formula#27
myii added a commit to myii/postgres-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
38f36ec 
* Automated using myii/ssf-formula#27
myii added a commit to myii/sudoers-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
dbf2327 
* Automated using myii/ssf-formula#27
myii added a commit to myii/influxdb-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
aa99896 
* Automated using myii/ssf-formula#27
myii added a commit to myii/libvirt-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
114ed81 
* Automated using myii/ssf-formula#27
myii added a commit to myii/nginx-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
c7119ce 
* Automated using myii/ssf-formula#27
myii added a commit to myii/prometheus-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
fee41c7 
* Automated using myii/ssf-formula#27
myii added a commit to myii/ufw-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
24ac11d 
* Automated using myii/ssf-formula#27
myii added a commit to myii/cron-formula that referenced this pull request Sep 9, 2019
@myii
ci(yamllint): add rule empty-values
11f23e5 
* Automated using myii/ssf-formula#27
myii added a commit to myii/chrony-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
5c35ac7 
* Automated using myii/ssf-formula#27
@myii myii mentioned this pull request Sep 10, 2019
Merged
myii added a commit to myii/vault-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
ece89fa 
* Automated using myii/ssf-formula#27
@myii myii mentioned this pull request Sep 10, 2019
Merged
myii added a commit to myii/collectd-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
768a78e 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
collectd-formula$ yamllint -s .
./pillar.example
  157:22    error    empty value in block mapping  (empty-values)
  158:20    error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/prometheus-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
1784b34 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
prometheus-formula$ yamllint -s .
./pillar.example
  78:25     error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/postfix-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
c9a4fc7 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
postfix-formula$ yamllint -s .
./pillar.example
  92:15     error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/nginx-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
3d48b1b 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
nginx-formula$ yamllint -s .
./pillar.example
  146:56    error    empty value in block mapping  (empty-values)
  147:76    error    empty value in block mapping  (empty-values)
  148:59    error    empty value in block mapping  (empty-values)
  150:22    error    empty value in block mapping  (empty-values)
  151:39    error    empty value in block mapping  (empty-values)
  152:39    error    empty value in block mapping  (empty-values)
  153:39    error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/template-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
70ed7e2 
* Automated using myii/ssf-formula#27
* Close saltstack-formulas#164
myii added a commit to myii/vim-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
f5e8b84 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
vim-formula$ yamllint -s .
./pillar.example
  21:8      error    empty value in block mapping  (empty-values)
  22:9      error    empty value in block mapping  (empty-values)
  23:8      error    empty value in block mapping  (empty-values)
  25:13     error    empty value in block mapping  (empty-values)
  26:15     error    empty value in block mapping  (empty-values)
  27:15     error    empty value in block mapping  (empty-values)
  28:15     error    empty value in block mapping  (empty-values)
  29:15     error    empty value in block mapping  (empty-values)
  30:12     error    empty value in block mapping  (empty-values)
  32:12     error    empty value in block mapping  (empty-values)
  34:18     error    empty value in block mapping  (empty-values)
  35:18     error    empty value in block mapping  (empty-values)
  37:8      error    empty value in block mapping  (empty-values)
  38:8      error    empty value in block mapping  (empty-values)
  39:13     error    empty value in block mapping  (empty-values)
  43:12     error    empty value in block mapping  (empty-values)

./test/salt/pillar/vim.sls
  7:12      error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/mysql-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
b87a28d 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
mysql-formula$ yamllint -s .
./mysql/osfamilymap.yaml
  46:14     error    empty value in block mapping  (empty-values)
  66:14     error    empty value in block mapping  (empty-values)
  67:14     error    empty value in block mapping  (empty-values)
  68:16     error    empty value in block mapping  (empty-values)
  69:17     error    empty value in block mapping  (empty-values)
  70:16     error    empty value in block mapping  (empty-values)
  87:7      error    empty value in block mapping  (empty-values)
  216:14    error    empty value in block mapping  (empty-values)
  217:17    error    empty value in block mapping  (empty-values)

./mysql/defaults.yaml
  29:10     error    empty value in block mapping  (empty-values)
  30:11     error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/openvpn-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
a437b3b 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
openvpn-formula$ yamllint -s .
./pillar.example
  81:23     error    empty value in block mapping  (empty-values)
  83:16     error    empty value in block mapping  (empty-values)
  114:21    error    empty value in block mapping  (empty-values)
  117:20    error    empty value in block mapping  (empty-values)
  124:21    error    empty value in block mapping  (empty-values)
  151:19    error    empty value in block mapping  (empty-values)
  152:19    error    empty value in block mapping  (empty-values)
  166:14    error    empty value in block mapping  (empty-values)
  169:21    error    empty value in block mapping  (empty-values)
  172:31    error    empty value in block mapping  (empty-values)
  212:14    error    empty value in block mapping  (empty-values)
  214:16    error    empty value in block mapping  (empty-values)
  219:21    error    empty value in block mapping  (empty-values)
  220:29    error    empty value in block mapping  (empty-values)
  221:14    error    empty value in block mapping  (empty-values)
  224:19    error    empty value in block mapping  (empty-values)
  225:19    error    empty value in block mapping  (empty-values)
  226:24    error    empty value in block mapping  (empty-values)
  228:28    error    empty value in block mapping  (empty-values)
  285:15    error    empty value in block mapping  (empty-values)
  286:12    error    empty value in block mapping  (empty-values)
  287:18    error    empty value in block mapping  (empty-values)
  296:20    error    empty value in block mapping  (empty-values)

./openvpn/defaults.yaml
  14:12     error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/bind-formula that referenced this pull request Sep 10, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
9163726 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
bind-formula$ yamllint -s .
./pillar-with-views.example
  1:1       warning  missing document start "---"  (document-start)
  2:89      error    line too long (93 > 88 characters)  (line-length)
  4:89      error    line too long (98 > 88 characters)  (line-length)
  5:51      warning  comment not indented like content  (comments-indentation)
  5:89      error    line too long (90 > 88 characters)  (line-length)
  6:1       error    trailing spaces  (trailing-spaces)
  8:89      error    line too long (104 > 88 characters)  (line-length)
  10:89     error    line too long (104 > 88 characters)  (line-length)
  11:89     error    line too long (114 > 88 characters)  (line-length)
  12:89     error    line too long (116 > 88 characters)  (line-length)
  14:1      error    trailing spaces  (trailing-spaces)
  16:89     error    line too long (121 > 88 characters)  (line-length)
  18:89     error    line too long (108 > 88 characters)  (line-length)
  20:89     error    line too long (97 > 88 characters)  (line-length)
  22:89     error    line too long (106 > 88 characters)  (line-length)
  23:22     warning  truthy value should be one of [false, true]  (truthy)
  23:89     error    line too long (97 > 88 characters)  (line-length)
  24:51     warning  comment not indented like content  (comments-indentation)
  24:89     error    line too long (110 > 88 characters)  (line-length)
  24:110    error    trailing spaces  (trailing-spaces)
  25:89     error    line too long (122 > 88 characters)  (line-length)
  26:19     warning  truthy value should be one of [false, true]  (truthy)
  27:19     warning  truthy value should be one of [false, true]  (truthy)
  29:89     error    line too long (113 > 88 characters)  (line-length)
  31:89     error    line too long (98 > 88 characters)  (line-length)
  33:89     error    line too long (104 > 88 characters)  (line-length)
  35:89     error    line too long (101 > 88 characters)  (line-length)
  36:51     warning  comment not indented like content  (comments-indentation)
  36:89     error    line too long (112 > 88 characters)  (line-length)
  36:112    error    trailing spaces  (trailing-spaces)
  37:89     error    line too long (122 > 88 characters)  (line-length)
  38:22     warning  truthy value should be one of [false, true]  (truthy)
  39:19     warning  truthy value should be one of [false, true]  (truthy)
  40:19     warning  truthy value should be one of [false, true]  (truthy)
  43:89     error    line too long (96 > 88 characters)  (line-length)
  44:89     error    line too long (119 > 88 characters)  (line-length)
  45:51     warning  comment not indented like content  (comments-indentation)
  46:1      error    trailing spaces  (trailing-spaces)
  50:89     error    line too long (99 > 88 characters)  (line-length)
  57:89     error    line too long (89 > 88 characters)  (line-length)
  70:1      error    trailing spaces  (trailing-spaces)
  71:89     error    line too long (96 > 88 characters)  (line-length)
  72:89     error    line too long (119 > 88 characters)  (line-length)
  73:51     warning  comment not indented like content  (comments-indentation)
  74:1      error    trailing spaces  (trailing-spaces)
  78:89     error    line too long (99 > 88 characters)  (line-length)
  85:89     error    line too long (89 > 88 characters)  (line-length)
  87:89     error    line too long (110 > 88 characters)  (line-length)
```
@myii myii force-pushed the feat/add-rule_empty-values_to-yamllint branch from 4ea8755 to 534b0eb Compare September 10, 2019 23:06
@myii
Copy link
Owner Author

myii commented Sep 10, 2019

All of the issues have been dealt with this and this PR finalised. Merge this once the generated PRs have been merged.

@myii myii merged commit 5f3f28d into master Sep 12, 2019
@myii
Copy link
Owner Author

myii commented Sep 12, 2019

All PRs merged except mysql-formula but I've requested some feedback on that one.

@myii myii deleted the feat/add-rule_empty-values_to-yamllint branch September 12, 2019 23:17
myii pushed a commit that referenced this pull request Sep 12, 2019
@semantic-release-bot
chore(release): 0.21.0 [skip ci]
ff855a1 
# [0.21.0](v0.20.0...v0.21.0) (2019-09-12)

### Code Refactoring

* **yamllint:** restructure `ignores` like `yaml-files` ([534b0eb](534b0eb))

### Features

* **bind:** add `yamllint` ignore rules for `pillar-with-views.example` ([5d3bbf1](5d3bbf1)), closes [/github.com//pull/27#issuecomment-529735409](https://github.com//github.com/myii/ssf-formula/pull/27/issues/issuecomment-529735409)
* **yamllint:** add rule `empty-values` ([e25c1ef](e25c1ef))
* **yamllint:** use new `yaml-files` setting ([ea3fbf3](ea3fbf3))
@myii
Copy link
Owner Author

myii commented Sep 12, 2019

🎉 This PR is included in version 0.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label Sep 12, 2019
myii added a commit that referenced this pull request Sep 12, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
1d418e9 
* Automated using #27
@myii myii mentioned this pull request Sep 12, 2019
Merged
myii added a commit to myii/mysql-formula that referenced this pull request Sep 14, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
9775305 
* Semi-automated using myii/ssf-formula#27
* Fix (or ignore) errors shown below:

```bash
mysql-formula$ yamllint -s .
./mysql/osfamilymap.yaml
  46:14     error    empty value in block mapping  (empty-values)
  66:14     error    empty value in block mapping  (empty-values)
  67:14     error    empty value in block mapping  (empty-values)
  68:16     error    empty value in block mapping  (empty-values)
  69:17     error    empty value in block mapping  (empty-values)
  70:16     error    empty value in block mapping  (empty-values)
  87:7      error    empty value in block mapping  (empty-values)
  216:14    error    empty value in block mapping  (empty-values)
  217:17    error    empty value in block mapping  (empty-values)

./mysql/defaults.yaml
  29:10     error    empty value in block mapping  (empty-values)
  30:11     error    empty value in block mapping  (empty-values)
```
myii added a commit to myii/mysql-formula that referenced this pull request Sep 14, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
2322ff6 
* Semi-automated using myii/ssf-formula#27
* Fix (or ignore) errors shown below:

```bash
mysql-formula$ yamllint -s .
./mysql/osfamilymap.yaml
  46:14     error    empty value in block mapping  (empty-values)
  66:14     error    empty value in block mapping  (empty-values)
  67:14     error    empty value in block mapping  (empty-values)
  68:16     error    empty value in block mapping  (empty-values)
  69:17     error    empty value in block mapping  (empty-values)
  70:16     error    empty value in block mapping  (empty-values)
  87:7      error    empty value in block mapping  (empty-values)
  216:14    error    empty value in block mapping  (empty-values)
  217:17    error    empty value in block mapping  (empty-values)

./mysql/defaults.yaml
  29:10     error    empty value in block mapping  (empty-values)
  30:11     error    empty value in block mapping  (empty-values)
```
noelmcloughlin pushed a commit to noelmcloughlin/golang-formula that referenced this pull request Nov 18, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
9a6e20d 
* Automated using myii/ssf-formula#27
blarghmatey pushed a commit to mitodl/nginx-formula that referenced this pull request Dec 17, 2019
@myii @blarghmatey
ci(yamllint): add rule empty-values & use new yaml-files setting
2d7a275 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
nginx-formula$ yamllint -s .
./pillar.example
  146:56    error    empty value in block mapping  (empty-values)
  147:76    error    empty value in block mapping  (empty-values)
  148:59    error    empty value in block mapping  (empty-values)
  150:22    error    empty value in block mapping  (empty-values)
  151:39    error    empty value in block mapping  (empty-values)
  152:39    error    empty value in block mapping  (empty-values)
  153:39    error    empty value in block mapping  (empty-values)
```
markbreedlove pushed a commit to mitodl/nginx-formula that referenced this pull request Dec 17, 2019
@myii
ci(yamllint): add rule empty-values & use new yaml-files setting
e8922d5 
* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
nginx-formula$ yamllint -s .
./pillar.example
  146:56    error    empty value in block mapping  (empty-values)
  147:76    error    empty value in block mapping  (empty-values)
  148:59    error    empty value in block mapping  (empty-values)
  150:22    error    empty value in block mapping  (empty-values)
  151:39    error    empty value in block mapping  (empty-values)
  152:39    error    empty value in block mapping  (empty-values)
  153:39    error    empty value in block mapping  (empty-values)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@myii