-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yamllint): add rule empty-values
& use new yaml-files
setting
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
added a commit
to myii/apt-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/iptables-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/sysctl-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/locale-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/keepalived-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/collectd-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/vim-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/golang-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/vsftpd-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/logrotate-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/fail2ban-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/dhcpd-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/mysql-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/timezone-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/rkhunter-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/php-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/users-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/systemd-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/syslog-ng-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/grafana-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/openvpn-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/deepsea-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/postgres-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/sudoers-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/influxdb-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/libvirt-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/nginx-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/prometheus-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/ufw-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/cron-formula
that referenced
this pull request
Sep 9, 2019
* Automated using myii/ssf-formula#27
myii
added a commit
to myii/chrony-formula
that referenced
this pull request
Sep 10, 2019
myii
added a commit
to myii/vault-formula
that referenced
this pull request
Sep 10, 2019
myii
added a commit
to myii/collectd-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash collectd-formula$ yamllint -s . ./pillar.example 157:22 error empty value in block mapping (empty-values) 158:20 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/prometheus-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash prometheus-formula$ yamllint -s . ./pillar.example 78:25 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/postfix-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash postfix-formula$ yamllint -s . ./pillar.example 92:15 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/nginx-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash nginx-formula$ yamllint -s . ./pillar.example 146:56 error empty value in block mapping (empty-values) 147:76 error empty value in block mapping (empty-values) 148:59 error empty value in block mapping (empty-values) 150:22 error empty value in block mapping (empty-values) 151:39 error empty value in block mapping (empty-values) 152:39 error empty value in block mapping (empty-values) 153:39 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/template-formula
that referenced
this pull request
Sep 10, 2019
* Automated using myii/ssf-formula#27 * Close saltstack-formulas#164
myii
added a commit
to myii/vim-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash vim-formula$ yamllint -s . ./pillar.example 21:8 error empty value in block mapping (empty-values) 22:9 error empty value in block mapping (empty-values) 23:8 error empty value in block mapping (empty-values) 25:13 error empty value in block mapping (empty-values) 26:15 error empty value in block mapping (empty-values) 27:15 error empty value in block mapping (empty-values) 28:15 error empty value in block mapping (empty-values) 29:15 error empty value in block mapping (empty-values) 30:12 error empty value in block mapping (empty-values) 32:12 error empty value in block mapping (empty-values) 34:18 error empty value in block mapping (empty-values) 35:18 error empty value in block mapping (empty-values) 37:8 error empty value in block mapping (empty-values) 38:8 error empty value in block mapping (empty-values) 39:13 error empty value in block mapping (empty-values) 43:12 error empty value in block mapping (empty-values) ./test/salt/pillar/vim.sls 7:12 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/mysql-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash mysql-formula$ yamllint -s . ./mysql/osfamilymap.yaml 46:14 error empty value in block mapping (empty-values) 66:14 error empty value in block mapping (empty-values) 67:14 error empty value in block mapping (empty-values) 68:16 error empty value in block mapping (empty-values) 69:17 error empty value in block mapping (empty-values) 70:16 error empty value in block mapping (empty-values) 87:7 error empty value in block mapping (empty-values) 216:14 error empty value in block mapping (empty-values) 217:17 error empty value in block mapping (empty-values) ./mysql/defaults.yaml 29:10 error empty value in block mapping (empty-values) 30:11 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/openvpn-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash openvpn-formula$ yamllint -s . ./pillar.example 81:23 error empty value in block mapping (empty-values) 83:16 error empty value in block mapping (empty-values) 114:21 error empty value in block mapping (empty-values) 117:20 error empty value in block mapping (empty-values) 124:21 error empty value in block mapping (empty-values) 151:19 error empty value in block mapping (empty-values) 152:19 error empty value in block mapping (empty-values) 166:14 error empty value in block mapping (empty-values) 169:21 error empty value in block mapping (empty-values) 172:31 error empty value in block mapping (empty-values) 212:14 error empty value in block mapping (empty-values) 214:16 error empty value in block mapping (empty-values) 219:21 error empty value in block mapping (empty-values) 220:29 error empty value in block mapping (empty-values) 221:14 error empty value in block mapping (empty-values) 224:19 error empty value in block mapping (empty-values) 225:19 error empty value in block mapping (empty-values) 226:24 error empty value in block mapping (empty-values) 228:28 error empty value in block mapping (empty-values) 285:15 error empty value in block mapping (empty-values) 286:12 error empty value in block mapping (empty-values) 287:18 error empty value in block mapping (empty-values) 296:20 error empty value in block mapping (empty-values) ./openvpn/defaults.yaml 14:12 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/bind-formula
that referenced
this pull request
Sep 10, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash bind-formula$ yamllint -s . ./pillar-with-views.example 1:1 warning missing document start "---" (document-start) 2:89 error line too long (93 > 88 characters) (line-length) 4:89 error line too long (98 > 88 characters) (line-length) 5:51 warning comment not indented like content (comments-indentation) 5:89 error line too long (90 > 88 characters) (line-length) 6:1 error trailing spaces (trailing-spaces) 8:89 error line too long (104 > 88 characters) (line-length) 10:89 error line too long (104 > 88 characters) (line-length) 11:89 error line too long (114 > 88 characters) (line-length) 12:89 error line too long (116 > 88 characters) (line-length) 14:1 error trailing spaces (trailing-spaces) 16:89 error line too long (121 > 88 characters) (line-length) 18:89 error line too long (108 > 88 characters) (line-length) 20:89 error line too long (97 > 88 characters) (line-length) 22:89 error line too long (106 > 88 characters) (line-length) 23:22 warning truthy value should be one of [false, true] (truthy) 23:89 error line too long (97 > 88 characters) (line-length) 24:51 warning comment not indented like content (comments-indentation) 24:89 error line too long (110 > 88 characters) (line-length) 24:110 error trailing spaces (trailing-spaces) 25:89 error line too long (122 > 88 characters) (line-length) 26:19 warning truthy value should be one of [false, true] (truthy) 27:19 warning truthy value should be one of [false, true] (truthy) 29:89 error line too long (113 > 88 characters) (line-length) 31:89 error line too long (98 > 88 characters) (line-length) 33:89 error line too long (104 > 88 characters) (line-length) 35:89 error line too long (101 > 88 characters) (line-length) 36:51 warning comment not indented like content (comments-indentation) 36:89 error line too long (112 > 88 characters) (line-length) 36:112 error trailing spaces (trailing-spaces) 37:89 error line too long (122 > 88 characters) (line-length) 38:22 warning truthy value should be one of [false, true] (truthy) 39:19 warning truthy value should be one of [false, true] (truthy) 40:19 warning truthy value should be one of [false, true] (truthy) 43:89 error line too long (96 > 88 characters) (line-length) 44:89 error line too long (119 > 88 characters) (line-length) 45:51 warning comment not indented like content (comments-indentation) 46:1 error trailing spaces (trailing-spaces) 50:89 error line too long (99 > 88 characters) (line-length) 57:89 error line too long (89 > 88 characters) (line-length) 70:1 error trailing spaces (trailing-spaces) 71:89 error line too long (96 > 88 characters) (line-length) 72:89 error line too long (119 > 88 characters) (line-length) 73:51 warning comment not indented like content (comments-indentation) 74:1 error trailing spaces (trailing-spaces) 78:89 error line too long (99 > 88 characters) (line-length) 85:89 error line too long (89 > 88 characters) (line-length) 87:89 error line too long (110 > 88 characters) (line-length) ```
4ea8755
to
534b0eb
Compare
All of the issues have been dealt with this and this PR finalised. Merge this once the generated PRs have been merged. |
All PRs merged except |
myii
pushed a commit
that referenced
this pull request
Sep 12, 2019
# [0.21.0](v0.20.0...v0.21.0) (2019-09-12) ### Code Refactoring * **yamllint:** restructure `ignores` like `yaml-files` ([534b0eb](534b0eb)) ### Features * **bind:** add `yamllint` ignore rules for `pillar-with-views.example` ([5d3bbf1](5d3bbf1)), closes [/github.com//pull/27#issuecomment-529735409](https://github.com//github.com/myii/ssf-formula/pull/27/issues/issuecomment-529735409) * **yamllint:** add rule `empty-values` ([e25c1ef](e25c1ef)) * **yamllint:** use new `yaml-files` setting ([ea3fbf3](ea3fbf3))
🎉 This PR is included in version 0.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
added a commit
to myii/mysql-formula
that referenced
this pull request
Sep 14, 2019
* Semi-automated using myii/ssf-formula#27 * Fix (or ignore) errors shown below: ```bash mysql-formula$ yamllint -s . ./mysql/osfamilymap.yaml 46:14 error empty value in block mapping (empty-values) 66:14 error empty value in block mapping (empty-values) 67:14 error empty value in block mapping (empty-values) 68:16 error empty value in block mapping (empty-values) 69:17 error empty value in block mapping (empty-values) 70:16 error empty value in block mapping (empty-values) 87:7 error empty value in block mapping (empty-values) 216:14 error empty value in block mapping (empty-values) 217:17 error empty value in block mapping (empty-values) ./mysql/defaults.yaml 29:10 error empty value in block mapping (empty-values) 30:11 error empty value in block mapping (empty-values) ```
myii
added a commit
to myii/mysql-formula
that referenced
this pull request
Sep 14, 2019
* Semi-automated using myii/ssf-formula#27 * Fix (or ignore) errors shown below: ```bash mysql-formula$ yamllint -s . ./mysql/osfamilymap.yaml 46:14 error empty value in block mapping (empty-values) 66:14 error empty value in block mapping (empty-values) 67:14 error empty value in block mapping (empty-values) 68:16 error empty value in block mapping (empty-values) 69:17 error empty value in block mapping (empty-values) 70:16 error empty value in block mapping (empty-values) 87:7 error empty value in block mapping (empty-values) 216:14 error empty value in block mapping (empty-values) 217:17 error empty value in block mapping (empty-values) ./mysql/defaults.yaml 29:10 error empty value in block mapping (empty-values) 30:11 error empty value in block mapping (empty-values) ```
noelmcloughlin
pushed a commit
to noelmcloughlin/golang-formula
that referenced
this pull request
Nov 18, 2019
blarghmatey
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash nginx-formula$ yamllint -s . ./pillar.example 146:56 error empty value in block mapping (empty-values) 147:76 error empty value in block mapping (empty-values) 148:59 error empty value in block mapping (empty-values) 150:22 error empty value in block mapping (empty-values) 151:39 error empty value in block mapping (empty-values) 152:39 error empty value in block mapping (empty-values) 153:39 error empty value in block mapping (empty-values) ```
markbreedlove
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash nginx-formula$ yamllint -s . ./pillar.example 146:56 error empty value in block mapping (empty-values) 147:76 error empty value in block mapping (empty-values) 148:59 error empty value in block mapping (empty-values) 150:22 error empty value in block mapping (empty-values) 151:39 error empty value in block mapping (empty-values) 152:39 error empty value in block mapping (empty-values) 153:39 error empty value in block mapping (empty-values) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yamllint
config to preventempty-values
& use newyaml-files
setting saltstack-formulas/template-formula#164