Refactor SongDatabase (1, 2) #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: refactor magic cache * refactor: move magic to magicApi * refactor: move maiTools api to class * refactor: remove SongPropertiesOverride type * refactor: create songDatabaseFactory * refactor: remove 'Link' check in create SongDatabase * fix: fix delete all cache * Revert "refactor: remove 'Link' check in create SongDatabase" This reverts commit b4aca47.
myjian
force-pushed
the
feature/refactor
branch
from
d9e7997
to
3bbb155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #98. This merge request replays #99 by @Luxusio but resolves conflicts.
Tested with test cases in https://github.com/myjian/mai-tools/blob/gh-pages/TESTING.md