Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sabnzbd test can show empty or incorrect message #584

Closed
Serneum opened this issue Dec 24, 2020 · 1 comment
Closed

Sabnzbd test can show empty or incorrect message #584

Serneum opened this issue Dec 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Serneum
Copy link
Contributor

Serneum commented Dec 24, 2020

Describe the bug
If I go to Settings -> Download Settings, set my SABnzbd Host to an invalid value, then click Test SABnzbd, I get a green message popup with no text. It look like an error pops up in the browser console as well:

VM209:1 Uncaught SyntaxError: Unexpected token U in JSON at position 0
    at JSON.parse (<anonymous>)
    at Object.success (config:2241)
    at o (jquery-1.7.2.min.js:2)
    at Object.fireWith [as resolveWith] (jquery-1.7.2.min.js:2)
    at w (jquery-1.7.2.min.js:4)
    at XMLHttpRequest.d (jquery-1.7.2.min.js:4)

If you test with a valid Host setting, you get a message stating that the API key was successfully verified. If you then switch to an invalid host, that message continue to pop up. My guess is that the error is being raised and the message is never updated because of it.

Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Branch / commit: python3-dev / d1d6989
@barbequesauce barbequesauce added the bug Something isn't working label Jan 2, 2021
davalanche added a commit to davalanche/mylar3 that referenced this issue Jan 13, 2021
@davalanche
FIX:(mylar3#584) "Test SABnzbd" button throws a SyntaxError as not al…
38a093f 
…l of the SABtest() responses are JSON encoded. Also simplified a bit by removing the "Get API" call as there is an explicit link to do that.
davalanche added a commit to davalanche/mylar3 that referenced this issue Jan 20, 2021
@davalanche
FIX:(mylar3#584) "Test SABnzbd" button throws a SyntaxError as not al…
4fef995 
…l of the SABtest() responses are JSON encoded. Also simplified a bit by removing the "Get API" call as there is an explicit link to do that.
barbequesauce pushed a commit that referenced this issue Jan 26, 2021
@davalanche @barbequesauce
FIX:(#584) "Test SABnzbd" button throws a SyntaxError as not all of t…
f8ddcee 
…he SABtest() responses are JSON encoded. Also simplified a bit by removing the "Get API" call as there is an explicit link to do that.
evilhero added a commit that referenced this issue Feb 19, 2021
@evilhero
python3-dev merge
b245a63 
- IMP: Check booktype before attempting to snatch non-booktype related issues with DDL (ie. issue vs TPB)
- IMP: Ignore weekly pack matches for DDL single issue searches
- IMP: Improved speed of ReCheck Files
- IMP: Speed up checking for non-existant issues during a ReCheck Files when seeing if issues are Archived or not
- IMP: Renamed Blacklisted_publishers to ignored_publishers
- IMP: Updated save settings so it doesn't create hundreds of commas as values in some instances when saving ignored_publishers
- IMP:(#382) Use alternate search patterns with DDL until some valid matches are found
- IMP: auto-correct DDL search query if series contains either ':' or '/'
- FIX:(#632) Searchbox: add a try/except around image retrieval incase image is not yet present on CV due to being a new series which causes search results for a query to not display
- FIX: Setup default value for StoryArc Folder Format if one is not provided.
- FIX: fixed sorting of Have column on non-alpha index
- FIX:(#626) When using CDH with NZBGet, would cause a 'queue' error related to NZBGet not actually having that field in the response
- FIX: Removed max-width from no fit mode to make it truly no fit (@nymitr)
- FIX: Made webviewer use correct relative path (@nymitr)
- FIX: Some cbr/cbz contain actual files in subfolder (@nymitr)
- FIX:(#584) "Test SABnzbd" button throws a SyntaxError as not all of the SABtest() responses are JSON encoded. Also simplified a bit by removing the "Get API" call as there is an explicit link to do that. (@davalanche)
- FIX: SABnzbd "Get API" link not working (tested against SABnzbd 3.1.1 and 2.3.9) (@davalanche)
- FIX: FIX for DDL Restart throwing a popup error in GUI from Manage DDL page (@davalanche)
- FIX: Fixed indentation issue which caused an error when trying to reload the DDL queue (@edimusxero)
barbequesauce pushed a commit that referenced this issue Mar 12, 2021
@evilhero @barbequesauce
python3-dev merge
d0c23bf 
- IMP: Check booktype before attempting to snatch non-booktype related issues with DDL (ie. issue vs TPB)
- IMP: Ignore weekly pack matches for DDL single issue searches
- IMP: Improved speed of ReCheck Files
- IMP: Speed up checking for non-existant issues during a ReCheck Files when seeing if issues are Archived or not
- IMP: Renamed Blacklisted_publishers to ignored_publishers
- IMP: Updated save settings so it doesn't create hundreds of commas as values in some instances when saving ignored_publishers
- IMP:(#382) Use alternate search patterns with DDL until some valid matches are found
- IMP: auto-correct DDL search query if series contains either ':' or '/'
- FIX:(#632) Searchbox: add a try/except around image retrieval incase image is not yet present on CV due to being a new series which causes search results for a query to not display
- FIX: Setup default value for StoryArc Folder Format if one is not provided.
- FIX: fixed sorting of Have column on non-alpha index
- FIX:(#626) When using CDH with NZBGet, would cause a 'queue' error related to NZBGet not actually having that field in the response
- FIX: Removed max-width from no fit mode to make it truly no fit (@nymitr)
- FIX: Made webviewer use correct relative path (@nymitr)
- FIX: Some cbr/cbz contain actual files in subfolder (@nymitr)
- FIX:(#584) "Test SABnzbd" button throws a SyntaxError as not all of the SABtest() responses are JSON encoded. Also simplified a bit by removing the "Get API" call as there is an explicit link to do that. (@davalanche)
- FIX: SABnzbd "Get API" link not working (tested against SABnzbd 3.1.1 and 2.3.9) (@davalanche)
- FIX: FIX for DDL Restart throwing a popup error in GUI from Manage DDL page (@davalanche)
- FIX: Fixed indentation issue which caused an error when trying to reload the DDL queue (@edimusxero)
@evilhero
Copy link
Collaborator

A year + in stale - going to assume resolved over the course of previous commits.

If not, please open a new issue with the relevant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evilhero @Serneum @barbequesauce