Eliminate endless loop in sabnzb queue #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilhero
reviewed
Apr 12, 2020
evilhero
reviewed
Apr 12, 2020
evilhero
requested changes
Apr 12, 2020
… downloader configuration
|
@evilhero Both of your comments should be addressed in that last commit. Let me know if we want to adjust anything else. |
evilhero
requested changes
Apr 13, 2020
evilhero
approved these changes
Apr 14, 2020
barbequesauce
added a commit
that referenced
this pull request
Apr 23, 2020
* FIX: default sort order not in descending order on history page * fix history default sort order * patch for carepackage to ensure removal of multiple keyed items on a single log entry * FIX: forgot the file option * FIX: fix for telegram notifs failing due to max retries exceeded, which would then lock the pp-queue * FIX: fix for DDL download breaking for some series * FIX: fix for simultaneous searches firing off when done using different search methods * FIX:(#225) If git wasn't in environment path, would accept failed output as a valid response and attempt to use that as commit/branch information * FIX: fix for incorrect error reference when encountering an SQlite error trap * FIX(#229) API response was not being handled properly by cherrypy * FIX:(#231) Carepackage fails to perform cleanup of temporary files and causes an error on Windows systems due to locked files * Fix crash if Mylar sees book that's a symlink to a nonexistant file * optional config.ini choice to use either [CVDBxxxx] or [Issue ID xxxxxx] (the default) in the notes field when metatagging. * FIX: provider_order would not respect ini settings (would tend to reorder based on code priority vs ini priority) * fix popup javascript error in importresults datatables due to extraneous html * Performance Tuning - speed up weekly pull check which was locking database * fix typo in search which would cause a traceback * removed logging line that captured data * update carepackage to ensure complete removal * Eliminate endless loop in sabnzb queue (#251) * Eliminate endless loop in nzb queue * Eliminate double for loop & ensure we use the correct nzb id based on downloader configuration * Handle paused sab queue by throwing a warning * fix a crash Co-authored-by: Barbeque Sauce <saucebarbeque@hotmail.com> Co-authored-by: Bran Tyslerx <btx@mxyzptlk.net> Co-authored-by: Evan Roth <evan.roth@gmail.com> Co-authored-by: AJ Slater <aj@slater.net> Co-authored-by: mylar3 <59849447+mylar3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up some issues in the nzb queue monitoring which:
In this case, if an nzb was no longer found in the queue within sab, it'd be loop endlessly looking for it. Solved by adding a quick check to see if the nzb we're looking for exists in the result set at all, and if not, return with a new status and log it. Eliminating the while loop altogether seems fine, as it was only ever looping through the same result from sabnzbd history.