(#432) Fixes search & post-processing related issues between similar named series on the watchlist #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld contain a matching title of another watchlisted series (ie. wrong matches)
barbequesauce
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for series that would match as an alternate naming possibility - would incorrectly take the alternate naming match instead of ensuring no other matches exist with the correct series titles (ie. Empyre would match to Empyre - Avengers, etc)
When trying to post-process issues similar as above - if no watchlisted series were present, but the series existed on the arc watchlist, would incorrectly take the wrong series as the matching title.
This PR should resolve all the matching problems as indicated above - however, in doing so, any any alternate series titles that are discovered when file parsing (not the
Alternate Search Namefield), are discarded atm in order to try and minimize incorrect matches going forward.