-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid unnecessary timezone conversion when use_numpy=True #354
Comments
Hi. Feel free to make PR. |
edwinwzhe
pushed a commit
to edwinwzhe/clickhouse-driver
that referenced
this issue
Jan 31, 2023
edwinwzhe
pushed a commit
to edwinwzhe/clickhouse-driver
that referenced
this issue
Jan 31, 2023
5 tasks
edwinwzhe
changed the title
avoid unnecessary timezone covertion when use_numpy=True
avoid unnecessary timezone conversion when use_numpy=True
Jan 31, 2023
xzkostyan
added a commit
that referenced
this issue
Feb 1, 2023
Avoid unnecessary timezone conversion (#354)
thanks for merging the PR @xzkostyan I am looking forward to contribute to the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi guys
Thanks for the excellent work. We are prototyping with ClickHouse and it is pretty amazing!
When I was benchmarking. I noticed a potential improvement for reading when
use_numpy=True
.I will create a PR if it is a sensible change in your view.
Basically, the issue is that
NumpyDateTimeColumnBase.apply_timezones_after_read
always cast the numpy array to pandas DateTimeIndex, convert timezone and then back to numpy array. This operation is not cheap and it is not always necessary. In our use case, we use UTC everywhere, it will be a nice speedup if we could avoid unnecessary tz conversion.The text was updated successfully, but these errors were encountered: