Add parameter chunk_size and default as 1

[MIracleyin]

No description provided.

[xzkostyan]

And of course test is required for this feature. See existing tests for execute_iter.

[xzkostyan]

If chunk_size is 1 it should be no additional overhead

rv = self.iter_process_ordinary_query(...)

return chunks(rv, chunk_size) if chunk_size > 1 else rv

[MIracleyin]

Yeah, it's much better.

[MIracleyin]

And of course test is required for this feature. See existing tests for execute_iter.

I am sorry, but I have no idea for testing it. May I use docker images that contain clickhouse and use Class tests.test_blocks.IteratorTestCase? I am a flashman as a contributor.

[xzkostyan]

Quite simple test for emitting execute_iter with chunk_size and asserting that size of chunk will be enough.

You can also run tests locally: https://clickhouse-driver.readthedocs.io/en/latest/development.html

[coveralls]

Coverage increased (+0.0009%) to 96.583% when pulling 4bb0495 on MIracleyin:master into aeae5c4 on mymarilyn:master.

[MIracleyin]

Oh, I see. I overlook development and look through How to Contribute.

[MIracleyin]

Hi, i using https://raw.githubusercontent.com/mymarilyn/clickhouse-driver/master/tests/docker-compose.yml. I replace "$ORG" to yandex and "$VERSION" to 21.12.3.32. When it started, I run py.test -v. But I get a lot of Error: RuntimeError: Error during communication. b'Code: 210. DB::NetException: Connection refused (localhost:9000). (NETWORK_ERROR)\n\n'

[MIracleyin]

Quite simple test for emitting execute_iter with chunk_size and asserting that size of chunk will be enough.

You can also run tests locally: https://clickhouse-driver.readthedocs.io/en/latest/development.html

And I also reference https://clickhouse-driver.readthedocs.io/en/latest/development.html and try it in docker, but I got the same Error. For test clickhouse, I user curl 127.0.0.1:9000 and get this
Port 9000 is for clickhouse-client program
You must use port 8123 for HTTP.

[xzkostyan]

Okay. You can use github actions in your forked repo: https://clickhouse-driver.readthedocs.io/en/latest/development.html#github-actions-in-forked-repository

[xzkostyan]

Good job!

[MIracleyin]

Good job!

Thanks for you! I learn a lot of skills about contribution.