Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout for INSERT queries without params. #45

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Fix timeout for INSERT queries without params. #45

merged 4 commits into from
Jul 24, 2018

Conversation

shotInLeg
Copy link
Contributor

With use classic INSERT request execute method throw timeout exception, code showing this https://pastebin.com/V2kNpynf

@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.004%) to 95.612% when pulling dc0a0e7 on shotInLeg:fix-timeout-insert into 9a20627 on mymarilyn:master.

@xzkostyan
Copy link
Member

It's okay. There is no CTE clause in INSERT expression now.

Write test for this case to keep coverage at the same level.

@xzkostyan xzkostyan merged commit cc666e6 into mymarilyn:master Jul 24, 2018
@mmcniece
Copy link

This breaks valid queries that do an insert into ... select from... can this be reverted or fixed to allow that? Example:

INSERT INTO test_v1
(
    val_1,
    val_2
)
SELECT
    val_1,
    val_2
FROM test_v2;

is a valid query but now fails with the error message:
ValueError: For use INSERT queries set params argument

@mmcniece
Copy link

This is also a functionality change, so it should not have been released as a patch number bump.

@xzkostyan
Copy link
Member

I've suddenly missed this breaking change with INSERT FROM SELECT.

This was reverted in 0.0.13.

@mmcniece
Copy link

No problem, thanks for the quick fix @xzkostyan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants