Rn/upgrade 63 4 ios jsi #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add thin JSI layer for fetching config via JS runtime.Everytime NSUSerdefaults get updated a message gets sent to notification center and the entire config gets sent to the NATIVE side via the Bridge. This ends up choking the bridge with a size of upto 600Kb everytime.
Old FLow
UI -> Set Key -> Update NS UserDefault -> Notify Observer -> Send Defaults Via bridge (600Kb)
NEW FLOW
UI -> Set Key -> Update NS UserDefault -> Notify Observer -> Send small message via bridge 100B -> Pull Config Via JSI
Perf Improvements.
Sizes are in KBs