Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypaint_tiled_surface_get_alpha() is missing from the generated .so on Linux #119

Closed
define-private-public opened this issue Mar 25, 2018 · 4 comments

Comments

@define-private-public
Copy link

I'm working on a C# binding at the moment, and was starting work on the TileSurface object/class/thingy. When I tried to call mypaint_tiled_surface_get_alpha() from my C# program, I got an exception saying that it "couldn't find the DLL entry point."

It's declared in the header file: https://github.com/mypaint/libmypaint/blob/master/mypaint-tiled-surface.h#L76

Looking at where I installed the libraries, I checked the .so:

me@machine:/usr/local/lib$ strings libmypaint-1.3.so.0 | sort | uniq | grep mypaint_tiled_surface | grep alpha
me@machine:/usr/local/lib$ strings libmypaint-1.3.so.0 | sort | uniq | grep mypaint_tiled_surface
mypaint_tiled_surface_begin_atomic
mypaint_tiled_surface_destroy
mypaint_tiled_surface_end_atomic
mypaint_tiled_surface_init
mypaint_tiled_surface_set_symmetry_state
mypaint_tiled_surface_tile_request_end
mypaint_tiled_surface_tile_request_start

Looks like it's not there.

@define-private-public
Copy link
Author

Checking the source file for tiled_surface, looks like that function hasn't been filled in there.

@briend
Copy link
Contributor

briend commented Mar 26, 2018

I think that get_alpha function should just be removed. All it did was call get_color and return the alpha component. Must have been deemed unnecessary at some point but not fully removed.

@jplloyd
Copy link
Member

jplloyd commented Oct 19, 2019

Just looked into this. It was never implemented. There is a fair bit of unused stuff in libmypaint - from half-begun or half-finished projects (most of them 6+ years old).

@jplloyd
Copy link
Member

jplloyd commented Feb 10, 2020

Implemented in 227d665 for the upcoming 1.5.0 release. Will probably be removed for 2.0.0 (it is entirely redundant, and was probably added/exposed by accident).

@jplloyd jplloyd closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants