Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SamBuilder can output SAM files #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SamBuilder can output SAM files #26

wants to merge 2 commits into from

Conversation

nh13
Copy link
Collaborator

@nh13 nh13 commented Jun 25, 2022

No description provided.

@nh13 nh13 self-assigned this Jun 25, 2022
@nh13 nh13 requested a review from NatPRoach June 28, 2022 01:32
NatPRoach
NatPRoach reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@NatPRoach NatPRoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a unit test to sambuilder with SAM output to prove that it outputs correctly / as expected?

@nh13
Copy link
Collaborator Author

nh13 commented Jun 28, 2022

Adding a unit test was the correct answer, as it uncovered a subtle bug (indexing a SAM file). Back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NatPRoach NatPRoach NatPRoach left review comments

Assignees

@nh13 nh13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh13 @NatPRoach